Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

76x Fireworks: Fix clang error #10746

Merged
merged 1 commit into from Aug 14, 2015
Merged

76x Fireworks: Fix clang error #10746

merged 1 commit into from Aug 14, 2015

Conversation

alja
Copy link
Contributor

@alja alja commented Aug 13, 2015

This is a cherry pick of a change 8a2f447 in #10595.

@alja
Copy link
Contributor Author

alja commented Aug 13, 2015

+1

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Aug 13, 2015
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@alja alja mentioned this pull request Aug 13, 2015
Closed
@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 180cca9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10746/7238/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@lgray lgray mentioned this pull request Aug 13, 2015
Merged
@lgray
Copy link
Contributor

lgray commented Aug 14, 2015

@davidlange6 can you please merge this one? It is blocking tests in other PRs.

@davidlange6
Copy link
Contributor

+1
ok!

cmsbuild added a commit that referenced this pull request Aug 14, 2015
@cmsbuild
Merge pull request #10746 from alja/clangErr76
82d6daa 
76x Fireworks: Fix clang error
@cmsbuild cmsbuild merged commit 82d6daa into cms-sw:CMSSW_7_6_X Aug 14, 2015
@alja alja deleted the clangErr76 branch May 11, 2017 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed tests-approved visualization-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alja @cmsbuild @Dr15Jones @lgray @davidlange6