Dynamic strip reco v4 #10805
Merged
Dynamic strip reco v4 #10805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added Loose, Medium and Tight tau ID discriminators with pileup weighted isolation - removal of deprecated tau ID discriminators from pat::Taus
- bug-fix: disable deltaBeta corrections for pileup weighted isolation discriminators
pf charged hadrons and tracks -> solves rare problem with 3-prongs having charge +/-3.
New charge cleaner module for taus
…to DynamicStripReco_v2
…riminators with deltaBeta correction
- updated thresholds for isolation WPs:
Loose = 2.5 GeV
Medium = 1.5 GeV
Tight = 0.8 GeV (no change)
- added Loose, Medium and Tight tau ID discriminators with pileup weighted isolation - removal of deprecated tau ID discriminators from pat::Taus
- bug-fix: disable deltaBeta corrections for pileup weighted isolation discriminators
pf charged hadrons and tracks -> solves rare problem with 3-prongs having charge +/-3.
…riminators with deltaBeta correction
- updated thresholds for isolation WPs:
Loose = 2.5 GeV
Medium = 1.5 GeV
Tight = 0.8 GeV (no change)
|
+1
@monttj please check if there are any issues to be resolved in this PR from your side |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
tests-started
and removed
tests-rejected
tests-pending
labels
|
@monttj please check if there are issues from AT side |
|
+1 |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working version of dynamic strip reco implemented in PRs 10215, 10605, 10802. Suggestions by Slava have been implemented and all matrix tests are passing. For an overview of what's included in this PR, see:
https://indico.cern.ch/event/434527/?filterActive=1&showDate=all&showSession=4#preview:1627952