Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for DAS query in ConfigBuilder 76X #10838

Merged
merged 3 commits into from Aug 24, 2015

Conversation

yetkinyilmaz
Copy link
Contributor

Two options added in order to pass options to DAS query, separately for main input and pile-up.
Initially needed in order to add larger sample when mixing (das_client.py --limit 0), however instead of coding this option in, a more generic flexibility was suggested ( @franzoni ).
One problem is if the dataset is too large (i.e. more than 600 files), the line:
https://github.com/yetkinyilmaz/cmssw/blob/das_query_76X_03/Configuration/Applications/python/ConfigBuilder.py#L140
gets stuck. This has to be fixed independently afterwards by more expert developers.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yetkinyilmaz for CMSSW_7_6_X.

Option for DAS query in ConfigBuilder 76X

It involves the following packages:

Configuration/Applications

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@yetkinyilmaz - the fix to your output-too-large problem is to avoid filling the linux buffer and move the p.stdout.read() line above the os.waitpid line

    tupleP = os.waitpid(p.pid, 0)
    eC=tupleP[1]
    count=count+1
    pipe=p.stdout.read()

@yetkinyilmaz
Copy link
Contributor Author

Thanks David, it works. I updated the two pull-requests for 76X and 75X.

On 18/08/15 14:51, David Lange wrote:

@yetkinyilmaz https://github.com/yetkinyilmaz - the fix to your
output-too-large problem is to avoid filling the linux buffer and move
the p.stdout.read() line above the os.waitpid line

|tupleP = os.waitpid(p.pid, 0) eC=tupleP[1] count=count+1
pipe=p.stdout.read() |


Reply to this email directly or view it on GitHub
#10838 (comment).

@cmsbuild
Copy link
Contributor

Pull request #10838 was updated. @cmsbuild, @franzoni, @davidlange6 can you please check and sign again.

davidlange6 added a commit that referenced this pull request Aug 24, 2015
Option for DAS query in ConfigBuilder 76X
@davidlange6 davidlange6 merged commit 0e81cf8 into cms-sw:CMSSW_7_6_X Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants