Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zmumu validation ported to 74X #10854

Merged

Conversation

cschomak
Copy link
Contributor

Zmumu validation of all-in-one-tool ported to 74X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cschomak for CMSSW_7_4_X.

Zmumu validation ported to 74X

It involves the following packages:

Alignment/OfflineValidation
MuonAnalysis/MomentumScaleCalibration

@diguida, @cerminar, @monttj, @cmsbuild, @vadler, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @frmeier, @argiro, @bellan, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

process.load("Geometry.CMSCommonData.cmsIdealGeometryXML_cfi")
process.load("Geometry.CommonDetUnit.globalTrackingGeometry_cfi")
#process.load("Geometry.CMSCommonData.cmsIdealGeometryXML_cfi")
process.load("Geometry.CommonDetUnit.globalTrackingGeometryDB_cfi")
process.load("RecoMuon.DetLayers.muonDetLayerGeometry_cfi")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cschomak is this inclusion really needed?

@mmusich
Copy link
Contributor

mmusich commented Aug 19, 2015

please test

@mmusich
Copy link
Contributor

mmusich commented Aug 19, 2015

@cschomak do you plan to fwd port to 76X and 75X too? We should have the usual approval procedure...

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cschomak
Copy link
Contributor Author

Yes I plan to port to 76X and 75X too. Shall I wait with the PR in 74X until the others are done? So far I only looked at 74X.
On the inclusion: It might not be necessary, I will test it

@mmusich
Copy link
Contributor

mmusich commented Aug 19, 2015

Just open sister PRs in all the active branches. Changes are trivial, we can approve everything in one go.

@cschomak
Copy link
Contributor Author

The include statement is not necessary and I deleted it

@cmsbuild
Copy link
Contributor

Pull request #10854 was updated. @diguida, @cerminar, @monttj, @cmsbuild, @vadler, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Aug 19, 2015

+1
for cschomak@e65ee30

@mmusich
Copy link
Contributor

mmusich commented Aug 19, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Aug 20, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 1, 2015
@cmsbuild cmsbuild merged commit e46130b into cms-sw:CMSSW_7_4_X Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants