New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zmumu validation ported to 74X #10854
Zmumu validation ported to 74X #10854
Conversation
A new Pull Request was created by @cschomak for CMSSW_7_4_X. Zmumu validation ported to 74X It involves the following packages: Alignment/OfflineValidation @diguida, @cerminar, @monttj, @cmsbuild, @vadler, @mmusich can you please review it and eventually sign? Thanks. |
process.load("Geometry.CMSCommonData.cmsIdealGeometryXML_cfi") | ||
process.load("Geometry.CommonDetUnit.globalTrackingGeometry_cfi") | ||
#process.load("Geometry.CMSCommonData.cmsIdealGeometryXML_cfi") | ||
process.load("Geometry.CommonDetUnit.globalTrackingGeometryDB_cfi") | ||
process.load("RecoMuon.DetLayers.muonDetLayerGeometry_cfi") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cschomak is this inclusion really needed?
please test |
@cschomak do you plan to fwd port to 76X and 75X too? We should have the usual approval procedure... |
The tests are being triggered in jenkins. |
Yes I plan to port to 76X and 75X too. Shall I wait with the PR in 74X until the others are done? So far I only looked at 74X. |
Just open sister PRs in all the active branches. Changes are trivial, we can approve everything in one go. |
The include statement is not necessary and I deleted it |
+1 |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…dation Zmumu validation ported to 74X
Zmumu validation of all-in-one-tool ported to 74X