New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix thread-safety issue with StreamerInputSource #10856
Fix thread-safety issue with StreamerInputSource #10856
Conversation
The previous way StreamerInputSource handled reading back RefCores lead to the probability that when dereferenced the RefCore would read from the wrong EventPrincipal when the job was using multiple streams becuase it was reusing the same EventPrincipalHolder for each event. The code has now been changed to make a new EventPrincipalHolder for each event.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X. Fix thread-safety issue with StreamerInputSource It involves the following packages: IOPool/Streamer @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…e_7_6 Fix thread-safety issue with StreamerInputSource
The previous way StreamerInputSource handled reading back RefCores
lead to the probability that when dereferenced the RefCore would read
from the wrong EventPrincipal when the job was using multiple streams
becuase it was reusing the same EventPrincipalHolder for each event.
The code has now been changed to make a new EventPrincipalHolder for
each event.