Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thread-safety issue with StreamerInputSource #10856

Merged

Conversation

Dr15Jones
Copy link
Contributor

The previous way StreamerInputSource handled reading back RefCores
lead to the probability that when dereferenced the RefCore would read
from the wrong EventPrincipal when the job was using multiple streams
becuase it was reusing the same EventPrincipalHolder for each event.
The code has now been changed to make a new EventPrincipalHolder for
each event.

The previous way StreamerInputSource handled reading back RefCores
lead to the probability that when dereferenced the RefCore would read
from the wrong EventPrincipal when the job was using multiple streams
becuase it was reusing the same EventPrincipalHolder for each event.
The code has now been changed to make a new EventPrincipalHolder for
each event.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Fix thread-safety issue with StreamerInputSource

It involves the following packages:

IOPool/Streamer

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 20, 2015
…e_7_6

Fix thread-safety issue with StreamerInputSource
@cmsbuild cmsbuild merged commit f32abf3 into cms-sw:CMSSW_7_6_X Aug 20, 2015
@Dr15Jones Dr15Jones deleted the threadSafeStreamerInputSource_7_6 branch August 26, 2015 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants