Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash due to invalid track status #10867

Merged
merged 4 commits into from Aug 20, 2015

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented Aug 20, 2015

There were some errors during cosmic muon reconstruction, division by zero.
Track propagation is skipped if the initial momentum of propagation is invalid in this PR.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_7_4_X.

Fix crash due to invalid track status

It involves the following packages:

TrackingTools/TrackAssociator

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @istaslis, @gpetruc, @cerati, @trocino, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Aug 20, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Aug 20, 2015

@jhgoh please make PRs for 75X and 76X

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Aug 20, 2015

+1

for #10867 80e0be1

  • this, somewhat a stop-gap fix to protect against bad/nan tracks
  • jenkins tests pass and comparisons with baseline show no differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 20, 2015
Fix crash due to invalid track status
@cmsbuild cmsbuild merged commit 45f7add into cms-sw:CMSSW_7_4_X Aug 20, 2015
@jhgoh jhgoh deleted the fixCrash254306NullPlane branch September 13, 2015 20:32
@jhgoh jhgoh restored the fixCrash254306NullPlane branch September 13, 2015 20:32
@jhgoh jhgoh deleted the fixCrash254306NullPlane branch September 13, 2015 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants