Adding e/gamma regression from Ecal Multifit in Run1/Run2 GTs (74X) #10883

mmusich · 2015-08-20T13:33:26Z

Summary of changes

Run1 simulation

Ideal: 74X_mcRun1_design_v1 : As DESRUN1_74_V7 with the following changes:
- New Egamma regressions based on ECAL multifit reconstruction.
Realistic: 74X_mcRun1_realistic_v1: As MCRUN1_74_V7 with the following changes:
- New Egamma regressions based on ECAL multifit reconstruction.
Heavy Ion: 74X_mcRun1_HeavyIon_v1: As MCHI1_74_V7 with the following changes:
- New Egamma regressions based on ECAL multifit reconstruction.
Proton Lead: 74X_mcRun1_pA_v1: As MCPA1_74_V7 with the following changes:
- New Egamma regressions based on ECAL multifit reconstruction.

Run1 data

Offline: 74X_dataRun1_v1: As GR_R_74_V14A with the following changes:
- New Egamma regressions based on ECAL multifit reconstruction;
- removing RelVal customized tags for L1;
- taxonomy change of SiPixelGenErrorDBObjectRcd tag.
HLT: 74X_dataRun1_HLT_frozen_v1: As GR_H_V57A with the following changes:
- Removing customized tags for L1;
- a snapshot time: 2015-08-20 12:10:16,000000.

Run2 simulation

Ideal: 74X_mcRun2_design_v1: As DESRUN2_74_V5 with the following changes:
- New Egamma regressions based on ECAL multifit reconstruction;
- fixing the PFCalibration version from v0 to v2.
Startup: 74X_mcRun2_startup_v1: As MCRUN2_74_V10 with the following changes:
- New Egamma regressions based on ECAL multifit reconstruction.
Asymptotic: 74X_mcRun2_asymptotic_v1: As MCRUN2_74_V11 with the following changes:
- New Egamma regressions based on ECAL multifit reconstruction.
Heavy Ion: 74X_mcRun2_HeavyIon_v1: As MCHI2_74_V6 with the following changes:
- New Egamma regressions based on ECAL multifit reconstruction.

Run2 data

Offline: 74X_dataRun2_v1: As GR_R_74_V15A with the following changes:
- New Egamma regressions based on ECAL multifit reconstruction;
- taxonomy change of SiPixelGenErrorDBObjectRcd tag;
- removing RelVal customized tags for L1.
HLT: 74X_dataRun2_HLT_frozen_v1: As GR_H_V58A with the following changes:
- Removing customized tags for L1;
- taxonomy change of EcalClusterLocalContCorrParametersRcd tag;
- adding label full for HcalElectronicsMapRcd;
- adding negative energy filter payload;
- a snapshot time: 2015-08-20 12:10:16,000000.

mmusich · 2015-08-20T13:36:09Z

please test

cmsbuild · 2015-08-20T13:36:15Z

The tests are being triggered in jenkins.

cmsbuild · 2015-08-20T13:36:17Z

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_7_4_X.

Adding e/gamma regression from Ecal Multifit in Run1/Run2 GTs (74X)

It involves the following packages:

Configuration/AlCa

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

cmsbuild · 2015-08-20T15:58:38Z

-1
Tested at: 0a310dd
When I ran the RelVals I found an error in the following worklfows:
1000.0 step1

DAS Error

1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10883/7505/summary.html

mmusich · 2015-08-21T07:01:18Z

@cmsbuild please test
let's try it again

cmsbuild · 2015-08-21T07:06:24Z

The tests are being triggered in jenkins.

cmsbuild · 2015-08-21T08:08:13Z

-1
Tested at: 0a310dd
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 21-Aug-2015 09:37:57 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 21-Aug-2015 09:38:18 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

140.53 step1

DAS Error

1000.0 step1

DAS Error

1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10883/7524/summary.html

mmusich · 2015-08-21T15:03:33Z

please test

cmsbuild · 2015-08-21T15:06:54Z

The tests are being triggered in jenkins.

slava77 · 2015-08-24T04:24:17Z

@mmusich @diguida
also, is there a Prompt GT as well with the egamma regression payloads?

mmusich · 2015-08-24T14:15:26Z

@slava77 so in order:

the Prompt GT with the new e/gamma regression is not yet ready, but can be by today
the SiPixelGenErrorDB change is pure taxonomy. We just removed the [account_name] from the tag name to make it less ugly, but the conditions are the very same.
the change in the L1 were customization that I think we don't require anymore. At least we removed them also in 75X, see this commit by @diguida link gitHub, link browser

mmusich · 2015-08-24T16:58:28Z

please test

cmsbuild · 2015-08-24T17:01:40Z

The tests are being triggered in jenkins.

cmsbuild · 2015-08-24T18:53:00Z

+1
Tested at: 0a310dd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10883/7594/summary.html

cmsbuild · 2015-08-24T19:41:34Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10883/7594/summary.html

slava77 · 2015-08-24T20:26:26Z

Looking at jenkins (alternative-comparisons) I see some oddity in 140.53 (HI data workflow):
[red is with this PR]
it looks like the bit assignment flipped somehow: the "ECAL triggered" plots are now empty and "CSC exclusive triggered" are now filled.

Somehow these HI Ecal plots are not showing up in the relmon diffs (the same files are analyzed in both; maybe the histograms with special characters and spaces in the title confuse the relmon)

There are more plots with L1-related changes, in run1 data (4.53 and 140.53 included), but those appear to make sense:
like these emulator/data comparisons now showing no failures

RECO products are not affected

mmusich · 2015-08-25T10:09:18Z

+1

mmusich · 2015-08-25T12:22:54Z

The GT for Prompt with the inclusion of the new egamma regressions is available: 74X_dataRun2_Prompt_v2, (diff with previous). I suppose I'll need to create a new one for express too, right?

cmsbuild · 2015-08-25T12:36:27Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

mmusich · 2015-09-02T08:02:49Z

@davidlange6 what should we do here? I need to integrate the JEC for miniAOD asap. Shall I start from those in this PR or again (sic!) from scratch. @gpetruc

davidlange6 · 2015-09-02T08:12:48Z

@mmusich - I was starting to look - presumably I can merge this and you can start from the GTs in this PR

Adding e/gamma regression from Ecal Multifit in Run1/Run2 GTs (74X)

davidlange6 · 2015-09-04T09:26:38Z

@mmusich - do we have the GTs with the new JECs?

mmusich · 2015-09-04T13:29:45Z

@davidlange6 we were missing the payloads for 25ns. This has been fixed in the meanwhile, will come soon(ish)

mmusich · 2015-09-08T08:47:26Z

@davidlange6 new JECs are included in #11172

Adding e/gamma regression from Ecal Multifit in Run1/Run2 GTs (74X)

0a310dd

cmsbuild added this to the Next CMSSW_7_4_X milestone Aug 20, 2015

cmsbuild added alca-pending comparison-pending orp-pending pending-signatures tests-pending labels Aug 20, 2015

mmusich mentioned this pull request Aug 20, 2015

Modifier to apply energy corrections to photons and electrons (miniAOD) for 75X #10690

Merged

cmsbuild added tests-started and removed tests-pending labels Aug 20, 2015

cmsbuild added tests-rejected and removed tests-started labels Aug 20, 2015

cmsbuild added tests-pending tests-started and removed tests-rejected tests-pending labels Aug 21, 2015

cmsbuild added tests-rejected and removed tests-started labels Aug 21, 2015

cmsbuild added tests-pending and removed tests-rejected tests-pending labels Aug 21, 2015

slava77 mentioned this pull request Aug 24, 2015

Modifier to apply energy corrections to photons and electrons (miniAOD) for 74X #10693

Closed

cmsbuild added tests-pending tests-started and removed tests-rejected tests-pending labels Aug 24, 2015

cmsbuild added tests-approved and removed tests-started labels Aug 24, 2015

cmsbuild added comparison-available and removed comparison-pending labels Aug 24, 2015

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Aug 25, 2015

davidlange6 added a commit that referenced this pull request Sep 2, 2015

Merge pull request #10883 from mmusich/GTs_for_74_v1

ecf7ad6

Adding e/gamma regression from Ecal Multifit in Run1/Run2 GTs (74X)

davidlange6 merged commit ecf7ad6 into cms-sw:CMSSW_7_4_X Sep 2, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding e/gamma regression from Ecal Multifit in Run1/Run2 GTs (74X) #10883

Adding e/gamma regression from Ecal Multifit in Run1/Run2 GTs (74X) #10883

mmusich commented Aug 20, 2015

mmusich commented Aug 20, 2015

cmsbuild commented Aug 20, 2015

cmsbuild commented Aug 20, 2015

cmsbuild commented Aug 20, 2015

mmusich commented Aug 21, 2015

cmsbuild commented Aug 21, 2015

cmsbuild commented Aug 21, 2015

mmusich commented Aug 21, 2015

cmsbuild commented Aug 21, 2015

slava77 commented Aug 24, 2015

mmusich commented Aug 24, 2015

mmusich commented Aug 24, 2015

cmsbuild commented Aug 24, 2015

cmsbuild commented Aug 24, 2015

cmsbuild commented Aug 24, 2015

slava77 commented Aug 24, 2015

mmusich commented Aug 25, 2015

mmusich commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

mmusich commented Sep 2, 2015

davidlange6 commented Sep 2, 2015

davidlange6 commented Sep 4, 2015

mmusich commented Sep 4, 2015

mmusich commented Sep 8, 2015

Adding e/gamma regression from Ecal Multifit in Run1/Run2 GTs (74X) #10883

Adding e/gamma regression from Ecal Multifit in Run1/Run2 GTs (74X) #10883

Conversation

mmusich commented Aug 20, 2015

Summary of changes

Run1 simulation

Run1 data

Run2 simulation

Run2 data

mmusich commented Aug 20, 2015

cmsbuild commented Aug 20, 2015

cmsbuild commented Aug 20, 2015

cmsbuild commented Aug 20, 2015

mmusich commented Aug 21, 2015

cmsbuild commented Aug 21, 2015

cmsbuild commented Aug 21, 2015

mmusich commented Aug 21, 2015

cmsbuild commented Aug 21, 2015

slava77 commented Aug 24, 2015

mmusich commented Aug 24, 2015

mmusich commented Aug 24, 2015

cmsbuild commented Aug 24, 2015

cmsbuild commented Aug 24, 2015

cmsbuild commented Aug 24, 2015

slava77 commented Aug 24, 2015

mmusich commented Aug 25, 2015

mmusich commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

mmusich commented Sep 2, 2015

davidlange6 commented Sep 2, 2015

davidlange6 commented Sep 4, 2015

mmusich commented Sep 4, 2015

mmusich commented Sep 8, 2015