Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parentage code out of the OutputModule base class #10889

Merged
merged 1 commit into from Aug 21, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Aug 20, 2015

This simple PR is a small first step on the road to a global::OutputModule for thread safety. The data in OutputModule containing parentage information is currently incompatible with a "global" thread safe module. Fortunately, this data and the corresponding functions are needed only by one output module, namely PoolOutputModule. This PR moves this information from the base class into the only derived class that needs it. The thread safety of the derived class will be addressed later.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_6_X.

Move parentage code out of the OutputModule base class

It involves the following packages:

FWCore/Framework
IOPool/Output

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1

Tested at: 5855261
I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10889/7521/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@wmtan
Copy link
Contributor Author

wmtan commented Aug 21, 2015

The unit test error exists in the base IB and is not caused by this PR.

davidlange6 added a commit that referenced this pull request Aug 21, 2015
Move parentage code out of the OutputModule base class
@davidlange6 davidlange6 merged commit 23cf9cc into cms-sw:CMSSW_7_6_X Aug 21, 2015
@wmtan wmtan deleted the OutputModuleThreadSafety1 branch August 24, 2015 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants