New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move parentage code out of the OutputModule base class #10889
Move parentage code out of the OutputModule base class #10889
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_6_X. Move parentage code out of the OutputModule base class It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
-1 Tested at: 5855261 ---> test runtestPhysicsToolsPatAlgos had ERRORS you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
The unit test error exists in the base IB and is not caused by this PR. |
Move parentage code out of the OutputModule base class
This simple PR is a small first step on the road to a global::OutputModule for thread safety. The data in OutputModule containing parentage information is currently incompatible with a "global" thread safe module. Fortunately, this data and the corresponding functions are needed only by one output module, namely PoolOutputModule. This PR moves this information from the base class into the only derived class that needs it. The thread safety of the derived class will be addressed later.