Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: merge in missing updates to mustache parameters #1090

Merged
merged 1 commit into from Oct 22, 2013

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Oct 17, 2013

Merge in cvs commit that was missed in migration to git.
This is critical for the performance of the mustache SCs.

Expect mild-to-significant improvement in raw E_reco/E_true in all regions of the ECAL.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_0_X.

bugfix: merge in missing updates to mustache parameters

It involves the following packages:

RecoEcal/EgammaCoreTools

@nclopezo, @smuzaffar, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@nclopezo
Copy link
Contributor

@nclopezo
Copy link
Contributor

-1
Sorry, I changed the Jenkins script and It seems that it only compiled and then skipped the tests, and then it thought that all was ok and posted the +1. I started the tests again and will post when they finish.

@nclopezo
Copy link
Contributor

@lgray
Copy link
Contributor Author

lgray commented Oct 18, 2013

@slava77 We checked the improvements to the energy resolution on our side with this bugfix, everything looks in order and energy resolution is back to nominal. Please merge asap.

@slava77
Copy link
Contributor

slava77 commented Oct 21, 2013

@slava77 working on it

@slava77
Copy link
Contributor

slava77 commented Oct 22, 2013

+1

Tested in CMSSW_7_0_X_2013-10-21-0200 1814a3f
No changes in standard collections.
Timing OK

The DQM validation picks up minor diffs only in regression values in oldpfPhotonValidator for gamma35 plot only.
FWLite script shows diffs in particleFlowSuperClusterECAL, generally small.
QCD or ttbar+PU has a bit more of a visible discrepancy

(TTBarPU wflow 202.0, log10(particleFlowSuperClusterECAL.energy())
all_sign260vsorig_ttbarpuwf202p0c_log10recosuperclusters_particleflowsuperclusterecal_particleflowsuperclusterecalbarrel_reco_obj_energy

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Oct 22, 2013
Reco fix -- Merge in missing updates to mustache parameters
@ktf ktf merged commit 650ece7 into cms-sw:CMSSW_7_0_X Oct 22, 2013
epalencia pushed a commit to epalencia/cmssw that referenced this pull request May 5, 2023
Add SC jets from extended tracks to event content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants