Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to latest pileup jet id in DQM #10923

Merged
merged 2 commits into from Aug 30, 2015
Merged

Switch to latest pileup jet id in DQM #10923

merged 2 commits into from Aug 30, 2015

Conversation

ahinzmann
Copy link
Contributor

Switch DQM to validate the latest available pileup jet ID training instead of the 53X training.

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Aug 24, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for CMSSW_7_6_X.

Switch to latest pileup jet id in DQM

It involves the following packages:

DQMOffline/JetMET

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@rappoccio, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso, @TaiSakuma, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ahinzmann
Copy link
Contributor Author

@webermat

@ahinzmann
Copy link
Contributor Author

Can this be tested?
It is essential to have it in a pre-release, otherwise DQM doesn't see the latest changes in pileup jet ID #10625.

@danduggan
Copy link
Contributor

please test

@danduggan
Copy link
Contributor

Hey @ahinzmann, doesn't this also need to go into 74/75x?

@ahinzmann
Copy link
Contributor Author

yes, I plan to backport after around of validation

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@danduggan
Copy link
Contributor

@ahinzmann, perfect, thanks for the confirmation

@cmsbuild
Copy link
Contributor

-1
Tested at: 3856cf2
When I ran the RelVals I found an error in the following worklfows:
4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 27-Aug-2015 18:22:24 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 194533 lumi: 329 event: 461582793
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module JetAnalyzer/'jetDQMAnalyzerAk4PFUncleaned'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::ValueMap
Looking for module label: pileupJetIdEvaluatorDQM
Looking for productInstanceName: full53xDiscriminant
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 27-Aug-2015 18:32:46 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module JetAnalyzer/'jetDQMAnalyzerAk4PFUncleaned'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::ValueMap
Looking for module label: pileupJetIdEvaluatorDQM
Looking for productInstanceName: full53xDiscriminant
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
----- Begin Fatal Exception 27-Aug-2015 18:33:46 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module JetAnalyzer/'jetDQMAnalyzerAk4PFUncleaned'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::ValueMap
Looking for module label: pileupJetIdEvaluatorDQM
Looking for productInstanceName: full53xDiscriminant
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 27-Aug-2015 18:41:13 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module JetAnalyzer/'jetDQMAnalyzerAk4PFUncleaned'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::ValueMap
Looking for module label: pileupJetIdEvaluatorDQM
Looking for productInstanceName: full53xDiscriminant
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 27-Aug-2015 18:42:29 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23615558
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module JetAnalyzer/'jetDQMAnalyzerAk4PFUncleaned'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::ValueMap
Looking for module label: pileupJetIdEvaluatorDQM
Looking for productInstanceName: full53xDiscriminant
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3.log
----- Begin Fatal Exception 27-Aug-2015 18:44:22 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23615558
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module JetAnalyzer/'jetDQMAnalyzerAk4PFUncleaned'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::ValueMap
Looking for module label: pileupJetIdEvaluatorDQM
Looking for productInstanceName: full53xDiscriminant
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 27-Aug-2015 18:45:25 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 191226 lumi: 398 event: 556818698
   [1] Running path 'dqmoffline_3_step'
   [2] Calling event method for module JetAnalyzer/'jetDQMAnalyzerAk4PFUncleaned'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::ValueMap
Looking for module label: pileupJetIdEvaluatorDQM
Looking for productInstanceName: full53xDiscriminant
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 27-Aug-2015 18:52:39 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module JetAnalyzer/'jetDQMAnalyzerAk4PFUncleaned'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::ValueMap
Looking for module label: pileupJetIdEvaluatorDQM
Looking for productInstanceName: full53xDiscriminant
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 27-Aug-2015 18:57:47 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module JetAnalyzer/'jetDQMAnalyzerAk4PFUncleaned'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::ValueMap
Looking for module label: pileupJetIdEvaluatorDQM
Looking for productInstanceName: full53xDiscriminant
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10923/7701/summary.html

@ahinzmann
Copy link
Contributor Author

with this fix the matrix runs for me

@cmsbuild
Copy link
Contributor

Pull request #10923 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

@danduggan
Copy link
Contributor

please test

On Thu, Aug 27, 2015 at 11:56 PM, cmsbuild notifications@github.com wrote:

Pull request #10923 #10923 was
updated. @cmsbuild https://github.com/cmsbuild, @danduggan
https://github.com/danduggan, @deguio https://github.com/deguio can
you please check and sign again.

—
Reply to this email directly or view it on GitHub
#10923 (comment).

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 9d17420
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10923/7704/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10923/7704/summary.html

@ahinzmann ahinzmann mentioned this pull request Aug 28, 2015
Merged
@danduggan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@ahinzmann ahinzmann mentioned this pull request Aug 28, 2015
Merged
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 30, 2015
@cmsbuild
Merge pull request #10923 from ahinzmann/pileupjetiddqm76
aa4173b 
Switch to latest pileup jet id in DQM
@cmsbuild cmsbuild merged commit aa4173b into cms-sw:CMSSW_7_6_X Aug 30, 2015
@cvuosalo cvuosalo mentioned this pull request Sep 1, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahinzmann @cmsbuild @danduggan @davidlange6