Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle LS based histos during LS transitions at HLT #10940

Merged
merged 1 commit into from Aug 31, 2015

Conversation

danduggan
Copy link
Contributor

Needed to improve performance for LS based histogram handling at the HLT during LS transitions.

@danduggan
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Aug 25, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @danduggan for CMSSW_7_4_X.

Better handle LS based histos during LS transitions at HLT

It involves the following packages:

DQMServices/Core

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

The jenkins tests job failed, please try again.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/7641/console

@cmsbuild
Copy link
Contributor

The jenkins tests job failed, please try again.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/7643/console

@danduggan
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@danduggan - lets also add this fix in 75x.

@danduggan
Copy link
Contributor Author

+1
thanks @davidlange6 for the suggestion - it's now pushed to both 75x (#11039) and 76x (#11040)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 31, 2015
Better handle LS based histos during LS transitions at HLT
@cmsbuild cmsbuild merged commit 8460ad6 into cms-sw:CMSSW_7_4_X Aug 31, 2015
@danduggan
Copy link
Contributor Author

@davidlange6, just spoke with HLT after their coordination meeting, and ultimately they will not need a patch on top of CMSSW_7_4_8 with this PR. Thanks in any case for being willing to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants