Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New steps for HI muon RegIt #10952

Merged

Conversation

echapon
Copy link
Contributor

@echapon echapon commented Aug 26, 2015

Two steps are added to the regional iterative tracking (RegIt) for heavy ion muons: the detached triplet step, and the "muon-seeded step", based on the equivalent step from pp iterative tracking.
The effect of this change is to slightly enhance the muon reconstruction efficiency, especially at high pt and in the endcaps, with very small impact on reconstruction timing.
Some illustrative plots can be found in slides 5-6 of https://indico.cern.ch/event/441327/contribution/11/attachments/1144636/1640681/chapon_dilepton_20150826.pdf.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @echapon (Emilien Chapon) for CMSSW_7_6_X.

New steps for HI muon RegIt

It involves the following packages:

RecoHI/HiMuonAlgos
RecoHI/HiTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @richard-cms, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

@echapon: Is there any relationship between this PR and #10653? Or are they independent?

@echapon
Copy link
Contributor Author

echapon commented Aug 26, 2015

These two PRs both affect muon regional iterative tracking for heavy ions, but they are independent.

@cvuosalo
Copy link
Contributor

+1

For #10952 03edf1f

For Heavy Ion muons, adding regional iterative tracking and detached triplet and muon-seeded steps.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-08-26-1100 show some very tiny differences for HI workflow 140.53, which are not significant. A test of workflow 140.53 with 70 events against baseline CMSSW_7_6_X_2015-08-24-1100 also shows a number of tiny differences which are not significant, with two examples shown at bottom. Processing time increases by about 4%:

Baseline
Max VSIZ 3145.04 on evt 38 ; max RSS 2697.1 on evt 59
Time av 22.2036 s/evt   max 108.176 s on evt 59
M1 Time av 22.2325 s/evt   max 108.176 s on evt 59

PR
Max VSIZ 3189.58 on evt 38 ; max RSS 2694.92 on evt 59
Time av 23.0261 s/evt   max 113.079 s on evt 59
M1 Time av 23.0663 s/evt   max 113.079 s on evt 59

Another measure of the Baseline==>PR timing difference:

Job total:  22.0545 s/ev ==> 22.8502 s/ev
Job total:  22.2708 s/ev ==> 23.0769 s/ev (excluding first event)

Times for the newly enabled modules (including first event):

       added      +0.82%         0.00 ms/ev ->       180.81 ms/ev hiEarlyMuons
       added      +0.00%         0.00 ms/ev ->         1.01 ms/ev hiRegitMuDetachedTripletStepSeedLayers
       added      +0.15%         0.00 ms/ev ->        34.16 ms/ev hiRegitMuDetachedTripletStepTrackCandidates
       added      +0.18%         0.00 ms/ev ->        40.30 ms/ev hiRegitMuonSeededTrackCandidatesInOut
       added      +2.11%         0.00 ms/ev ->       464.92 ms/ev hiEarlyGeneralTracks
       added      +0.04%         0.00 ms/ev ->         8.34 ms/ev hiRegitMuonSeededTracksInOut
       added      +0.02%         0.00 ms/ev ->         4.16 ms/ev hiRegitMuDetachedTripletStepTracks
       added      +0.00%         0.00 ms/ev ->         0.17 ms/ev hiRegitMuonSeededTrackCandidatesOutIn
       added      +0.00%         0.00 ms/ev ->         0.06 ms/ev hiRegitMuonSeededTracksOutInSelector
       added      +0.00%         0.00 ms/ev ->         0.05 ms/ev hiRegitMuDetachedTripletStepClusters
       added      +0.01%         0.00 ms/ev ->         2.47 ms/ev hiRegitMuonSeededSeedsInOut
       added      +0.00%         0.00 ms/ev ->         0.23 ms/ev hiRegitMuonSeededTracksInOutSelector
       added      +0.00%         0.00 ms/ev ->         0.08 ms/ev hiRegitMuonSeededTracksOutIn
       added      +0.02%         0.00 ms/ev ->         4.97 ms/ev hiRegitMuDetachedTripletStepSeeds
       added      +0.00%         0.00 ms/ev ->         0.85 ms/ev hiRegitMuonSeededSeedsOutIn
       added      +0.00%         0.00 ms/ev ->         0.14 ms/ev hiRegitMuDetachedTripletStepSelector

Examples of small differences:
jetptratio
numtracks

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Aug 27, 2015
@davidlange6 davidlange6 merged commit 95b9ffe into cms-sw:CMSSW_7_6_X Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants