Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New steps for HI muon RegIt #10953

Merged

Conversation

echapon
Copy link
Contributor

@echapon echapon commented Aug 26, 2015

Two steps are added to the regional iterative tracking (RegIt) for heavy ion muons: the detached triplet step, and the "muon-seeded step", based on the equivalent step from pp iterative tracking.
This PR is a 75X backport of #10952

Conflicts:
	RecoHI/HiTracking/python/MergeTrackCollectionsHI_cff.py
Conflicts:
	RecoHI/HiMuonAlgos/python/HiRegitMuonDetachedTripletStep_cff.py
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @echapon (Emilien Chapon) for CMSSW_7_5_X.

New steps for HI muon RegIt

It involves the following packages:

RecoHI/HiMuonAlgos
RecoHI/HiTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @richard-cms, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2015

@cmsbuild please test

@echapon please post some slides to performance changes, preferably showing both physics effects (efficiencies/fake rates) and the technical performance (CPU). For the physics side, I suppose the change was discussed in a meeting already (if so, a link would be nice)

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2015

nevermind, slides are available in #10952

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #10953 c616f47

For Heavy Ion muons, adding regional iterative tracking and detached triplet and muon-seeded steps. #10952 is the 76X version of this PR, and it has already been approved by Reco.

The code changes are satisfactory. Jenkins tests against baseline CMSSW_7_5_X_2015-08-26-1100 show some very tiny, insignificant differences for HI workflow 140.53. See #10952 for details about timing changes.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Aug 27, 2015
@davidlange6 davidlange6 merged commit 574ae69 into cms-sw:CMSSW_7_5_X Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants