Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug preventing the use of a local cache #11010

Merged
merged 1 commit into from Aug 31, 2015

Conversation

Dr15Jones
Copy link
Contributor

The last change to the logic of when a local cache could be used had
an error which accidently disabled any use of a local cache. This change
corrects the logic and a quick test shows that local caching is working
again.

The last change to the logic of when a local cache could be used had
an error which accidently disabled any use of a local cache. This change
corrects the logic and a quick test shows that local caching is working
again.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X.

Fix bug preventing the use of a local cache

It involves the following packages:

Utilities/StorageFactory

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 31, 2015
Fix bug preventing the use of a local cache
@cmsbuild cmsbuild merged commit 4696841 into cms-sw:CMSSW_7_5_X Aug 31, 2015
@Dr15Jones Dr15Jones deleted the fixLocalCaching_7_5 branch September 24, 2015 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants