Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clang static analyzer warning using namespace in header #11017

Merged
merged 1 commit into from Aug 30, 2015
Merged

fix clang static analyzer warning using namespace in header #11017

merged 1 commit into from Aug 30, 2015

Conversation

gartung
Copy link
Member

@gartung gartung commented Aug 28, 2015

No description provided.

@gartung
Copy link
Member Author

gartung commented Aug 28, 2015

@Dr15Jones

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Aug 28, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_6_X.

fix clang static analyzer warning using namespace in header

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 74b48eb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11017/7730/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11017/7730/summary.html

davidlange6 added a commit that referenced this pull request Aug 30, 2015
@davidlange6
Merge pull request #11017 from gartung/L1Trigger-L1TCalorimeter-fix-c…
705db6e 
…lang-warning

fix clang static analyzer warning using namespace in header
@davidlange6 davidlange6 merged commit 705db6e into cms-sw:CMSSW_7_6_X Aug 30, 2015
@gartung gartung deleted the L1Trigger-L1TCalorimeter-fix-clang-warning branch September 1, 2015 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available l1-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gartung @cmsbuild @Dr15Jones @davidlange6