Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #11022: Make surface deformation plots much faster #11023

Merged
merged 10 commits into from Nov 4, 2015

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Aug 28, 2015

The time it takes to run the validation itself does not change noticeably. The time it takes to make the plots decreases by a lot (<1 minute per curve, down from >~10 minutes per curve). The plots themselves are identical to before.

Also some cleanup of unused templates in alternateValidationTemplates, without losing any functionality.

- CosmicsOfflineValidation_Deformations can already be done (and is done) in other ways
- add an option to mimic the primary part of yResidualsOfflineValidation; the rest appears to be specific to a long time ago
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_7_5_X.

Backport of #11022: Make surface deformation plots much faster

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @frmeier, @mmusich, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #11023 was updated. @cmsbuild, @mmusich, @diguida, @cerminar can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Aug 31, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@hroskes
Copy link
Contributor Author

hroskes commented Sep 17, 2015

@cmsbuild sorry, I found a bug

@cmsbuild
Copy link
Contributor

Pull request #11023 was updated. @cmsbuild, @mmusich, @diguida, @cerminar can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Sep 17, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Oct 30, 2015

+1
backport of #11022

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 4, 2015
Backport of #11022: Make surface deformation plots much faster
@cmsbuild cmsbuild merged commit 0fa6a68 into cms-sw:CMSSW_7_5_X Nov 4, 2015
@hroskes hroskes deleted the faster-surface-shapes-75X branch November 4, 2015 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants