Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate modules used by the HLT menu to multithreading (L1) (76x) #11072

Merged
merged 1 commit into from Sep 3, 2015
Merged

migrate modules used by the HLT menu to multithreading (L1) (76x) #11072

merged 1 commit into from Sep 3, 2015

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 2, 2015

  • change all configuration parameters into const members
  • initialise them in the member initializer list
  • remove unused methods and member variables
  • remove "using namespace" from header file
  • change into a global::EDProducer

@fwyzard
L1TCaloUpgradeToGCTConverter: change into a global::EDProducer
7619f6e 
  - change all configuration parameters into const members
  - initialise them in the member initializer list
  - remove unused methods and member variables
  - remove "using namespace" from header file
  - change into a global::EDProducer
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 2, 2015

forward port of #10956

@fwyzard fwyzard mentioned this pull request Sep 2, 2015
Closed
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 2, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_6_X.

L1TCaloUpgradeToGCTConverter: change into a global::EDProducer

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 2, 2015

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 2, 2015

supersedes #10956

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 2, 2015

tracked at #10964

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

The tests are being triggered in jenkins.

@fwyzard fwyzard mentioned this pull request Sep 2, 2015
Closed
@fwyzard fwyzard changed the title L1TCaloUpgradeToGCTConverter: change into a global::EDProducer migrate modules used by the HLT menu to multithreading (L1) (76x) Sep 2, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

+1
Tested at: 7619f6e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11072/7803/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6acf0f1
97c4b3d
0f7191b
4720ec2
78e70d3
bba7104
5ec3e31
d8454f7
9923534
55ac7a3
de24a50
8d1a1a4
2087e26
0ebdd65
8adfd61
4d7c05e
f5bc1a6
7aa0033
62ef4ea
626e6bc
eecf9e3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11072/7803/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11072/7803/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11072/7803/summary.html

davidlange6 added a commit that referenced this pull request Sep 3, 2015
@davidlange6
Merge pull request #11072 from fwyzard/migrate_to_multithreading_76x_L1
4aedaf2 
migrate modules used by the HLT menu to multithreading (L1) (76x)
@davidlange6 davidlange6 merged commit 4aedaf2 into cms-sw:CMSSW_7_6_X Sep 3, 2015
@fwyzard fwyzard deleted the migrate_to_multithreading_76x_L1 branch September 23, 2015 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available l1-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fwyzard @cmsbuild @davidlange6