make EcalRingCalibrationTools thread safe (76x)

[fwyzard]

Implement a minimal set of changes to EcalRingCalibrationTools to make its initialisation and usage thead-safe.
In particular, this should make HLTEcalPhiSymFilter thread-safe again.

Note that EcalRingCalibrationTools is still non-compliant with the CMS coding rules, and should be rewritten either as an ESProducer, or as a non-static data member of an EDProducer.

[fwyzard]

please test

[fwyzard]

+1

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_6_X.

make EcalRingCalibrationTools thread safe (76x)

It involves the following packages:

Calibration/Tools
HLTrigger/special

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[fwyzard]

@bmarzocc , can you check if there is an alternative, more CMS-compliant approach available ?

[fwyzard]

tracked at #10964

[cmsbuild]

-1
Tested at: 3a36c22
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-02-1100/src/Calibration/Tools/src/GenericHouseholder.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-02-1100/src/Calibration/Tools/src/GenericMinL3Algorithm.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-02-1100/src/Calibration/Tools/src/HouseholderDecomposition.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-02-1100/src/Calibration/Tools/src/InvMatrixCommonDefs.cc 
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-02-1100/src/Calibration/Tools/src/EcalRingCalibrationTools.cc:1:
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-02-1100/src/Calibration/Tools/interface/EcalRingCalibrationTools.h:51:23: error: 'thread_guard' attribute requires a string
  [[cms::thread_guard(isInitializedFromGeometry_)]]
                      ^
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-02-1100/src/Calibration/Tools/src/InvMatrixUtils.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-02-1100/src/Calibration/Tools/src/MinL3AlgoUniv.cc 
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-02-1100/src/Calibration/Tools/src/HouseholderDecomposition.cc:7:


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11093/7842/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11093/7842/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11093/7842/summary.html

[fwyzard]

@Dr15Jones , do I need to use a different syntax to make LLVM/clang happy ?

[bmarzocc]

@fwyzard Is an alternative still needed? An alternative tool in CMSSW for extracting the ringID is this one:

https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_X/Calibration/EcalCalibAlgos/src/EcalGeomPhiSymHelper.cc

however it is not used and maintained anymore, so don't know if it works correctly with the latest CMSSW version.

[fwyzard]

I'd let David comment if we are happy with my minimal fix, it if something better is needed long term. Ciao, .Andrea

[davidlange6]

Am I mistaken that computing the ringID from a DetId is more than a few lines of code?

On Sep 3, 2015, at 1:38 PM, Badder Marzocchi notifications@github.com wrote:

@fwyzard Is an alternative still needed? An alternative tool in CMSSW for extracting the ringID is this one:

https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_X/Calibration/EcalCalibAlgos/src/EcalGeomPhiSymHelper.cc

however it is not used and maintained anymore, so don't know if it works correctly with the latest CMSSW version.

—
Reply to this email directly or view it on GitHub.

[Dr15Jones]

Yeah, the name in the thread_guard statement must be quoted
[[cms::thread_guard("isInitializedFromGeometry_")]]

[Dr15Jones]

My thoughts are what Andrea has done is fine for an emergency patch but this code violates CMSSW coding policies and we need a fix. This design is not a good long term pattern for handling threaded code.

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #11093 was updated. @cmsbuild, @mmusich, @diguida, @cerminar can you please check and sign again.

[Dr15Jones]

Sorry I missed it the first time.

[cmsbuild]

+1
Tested at: 300e779
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11093/7866/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11093/7866/summary.html

[mmusich]

+1
for fwyzard@300e779

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1