Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT BPTX added #11108

Merged
merged 1 commit into from Sep 16, 2015
Merged

HLT BPTX added #11108

merged 1 commit into from Sep 16, 2015

Conversation

KiSooLee
Copy link
Contributor

@KiSooLee KiSooLee commented Sep 3, 2015

HLT_HIL2Mu3BPTX, HLT_HIL3Mu3BPTX, HLT_HIL1DoubleMu0BPTX, HLT_HIL2DoubleMu0BPTX added

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

A new Pull Request was created by @KiSooLee for CMSSW_7_4_X.

HLT BPTX added

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@rociovilar, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@KiSooLee
Copy link
Contributor Author

KiSooLee commented Sep 8, 2015

This branch is almost same with base branch.
But previously there were some unnecessary files.
According to https://github.com/cms-sw/cmssw/pull/10813/files
HLT_User_cff.py
HLTrigger/Configuration/python/HLT_User_cff.py
Are unnecessary file.
So I want to merge without these two files.

@ghost
Copy link

ghost commented Sep 8, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2015

@deguio
Copy link
Contributor

deguio commented Sep 11, 2015

+1
it seems to me that these changes are present in 76 and 75 already.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 16, 2015
@cmsbuild cmsbuild merged commit 8f8c933 into cms-sw:CMSSW_7_4_X Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants