Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hydjet2 and Hydjet1 #11131

Merged
merged 14 commits into from Oct 29, 2015
Merged

Update Hydjet2 and Hydjet1 #11131

merged 14 commits into from Oct 29, 2015

Conversation

wouf
Copy link
Contributor

@wouf wouf commented Sep 4, 2015

Bug fixes and minor updates of Hydjet2

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

A new Pull Request was created by @wouf for CMSSW_7_6_X.

Update Hydjet2

It involves the following packages:

GeneratorInterface/Hydjet2Interface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@wouf wouf changed the title Update Hydjet2 Update Hydjet2 and Hydjet1 Sep 4, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

Pull request #11131 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please check and sign again.

@covarell
Copy link
Contributor

What is the plan to move Hydjet2 to cmsdist rather than CMSSW, as discussed at the GEN meeting?

@covarell
Copy link
Contributor

Hi Andrey (please continue conversation here, not in private emails),

I know Hydjet is not included in external generators. My question was exactly if there is a plan to move it there.

@wouf
Copy link
Contributor Author

wouf commented Sep 15, 2015

I do not understand the reason for this. Also how it's possible? Hydjet 2 it is the interface of HYDJET++ and from the code point of view it's the different programs. Could You please point me to the meeting where it was discussed? What was the motivation of this?

@wouf
Copy link
Contributor Author

wouf commented Sep 17, 2015

Can anybody answer that?

@covarell
Copy link
Contributor

This was discussed in the GEN meeting with Kurt Jung
https://indico.cern.ch/event/407404/

The normal way MC generators are used in CMS is not to copy the generator code in CMSSW, as it seems the case for Hydjet and other generators used in HI.

Generators are kept in an external repository with their own versioning, independent of CMSSW, and then we maintain in CMSSW just an interface which calls the generator in order to produce the result in CMS-compliant formats. This ensures that generator developments and CMSSW developments go in parallel, because generator authors are not in general CMS people.

Why for HI this is different?

@wouf
Copy link
Contributor Author

wouf commented Sep 17, 2015

For Hydjets and Pyquen the story is different. Hydjet 1: main authors is in CMS HI group. Hydjet 1 at this moment used only in CMS. The same story for Pyquen. Hydjet 2: it is the next generation of Hydjet 1, based on HYDJET++, but with different development strategy (for example at this moment we discuss the possibility of migration of Hydjet 2 (but not HYDJET++) to the Pythia 8). Hydjet 2 is made specially for CMS HI.

@mkirsano
Copy link
Contributor

hydjet 1.8 and hydjet++ 2.1 are in GENSER. They are downloaded there from the author's web site. So, technically it is possible to make hydjet++ an external package of cmssw (i.e. add it to cmsdist).
On the other hand, if this package is not used and developed outside CMS. there is a git repository
https://github.com/cms-externals. It is possible to keep and develop hydjet++ there. cmsdist can take the code from there using git commands.

@wouf
Copy link
Contributor Author

wouf commented Sep 17, 2015

This PR was made for Hydjet2_2_0_patch1 and Hydjet1_9_patch1. Hydjet++ is used outside the CMS, but Hydjet 2, which is already included to CMSSW (such as Hydjet1.9) is not the same as HYDJET++.

@wouf
Copy link
Contributor Author

wouf commented Sep 18, 2015

Anyway this PR is just bug fixes for Hydjet 1.9 and Hydjet 2.2.0. So we need it before the next HI MC production.

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Pull request #11131 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please check and sign again.

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9324/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 29, 2015
@cmsbuild cmsbuild merged commit 139d4f6 into cms-sw:CMSSW_7_6_X Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants