New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hydjet2 and Hydjet1 #11131
Update Hydjet2 and Hydjet1 #11131
Conversation
A new Pull Request was created by @wouf for CMSSW_7_6_X. Update Hydjet2 It involves the following packages: GeneratorInterface/Hydjet2Interface @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks. |
What is the plan to move Hydjet2 to cmsdist rather than CMSSW, as discussed at the GEN meeting? |
Hi Andrey (please continue conversation here, not in private emails), I know Hydjet is not included in external generators. My question was exactly if there is a plan to move it there. |
I do not understand the reason for this. Also how it's possible? Hydjet 2 it is the interface of HYDJET++ and from the code point of view it's the different programs. Could You please point me to the meeting where it was discussed? What was the motivation of this? |
Can anybody answer that? |
This was discussed in the GEN meeting with Kurt Jung The normal way MC generators are used in CMS is not to copy the generator code in CMSSW, as it seems the case for Hydjet and other generators used in HI. Generators are kept in an external repository with their own versioning, independent of CMSSW, and then we maintain in CMSSW just an interface which calls the generator in order to produce the result in CMS-compliant formats. This ensures that generator developments and CMSSW developments go in parallel, because generator authors are not in general CMS people. Why for HI this is different? |
For Hydjets and Pyquen the story is different. Hydjet 1: main authors is in CMS HI group. Hydjet 1 at this moment used only in CMS. The same story for Pyquen. Hydjet 2: it is the next generation of Hydjet 1, based on HYDJET++, but with different development strategy (for example at this moment we discuss the possibility of migration of Hydjet 2 (but not HYDJET++) to the Pythia 8). Hydjet 2 is made specially for CMS HI. |
hydjet 1.8 and hydjet++ 2.1 are in GENSER. They are downloaded there from the author's web site. So, technically it is possible to make hydjet++ an external package of cmssw (i.e. add it to cmsdist). |
This PR was made for Hydjet2_2_0_patch1 and Hydjet1_9_patch1. Hydjet++ is used outside the CMS, but Hydjet 2, which is already included to CMSSW (such as Hydjet1.9) is not the same as HYDJET++. |
Anyway this PR is just bug fixes for Hydjet 1.9 and Hydjet 2.2.0. So we need it before the next HI MC production. |
+1 |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Bug fixes and minor updates of Hydjet2