Preparing to include Method 3 result into HBHERecHit

[igv4321]

Making space for storing "method 3" energy in HBHERecHit,
at the request of "Early 2015 Physics Commissioning" group.

[cmsbuild]

A new Pull Request was created by @igv4321 (Igor Volobouev) for CMSSW_7_6_X.

Preparing to include Method 3 result into HBHERecHit

It involves the following packages:

DataFormats/HcalRecHit
RecoLocalCalo/HcalRecAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 85f69f8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11213/7986/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11213/7986/summary.html

[slava77]

+1

for #11213 9cae790

• code changes are in line with the previous change for the rawEnergy. I wanted to suggest something simpler, but ended up retracing to a similar result.
• the increase in rechit size on disk will stay in RECO tier, which shouldn't be a big deal considering its short lifetime.
• jenkins tests pass and comparisons with the baseline show no difference as expected (the new methods are not used yet)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[slava77]

Somewhat more compact version is the following.
You can add the method detection flags to just one single helper (no need to introduce a separate helper for that.
The example is detecting presence of a method float a()

template<typename T> struct AHelper {
  template<typename B> static int  test(decltype(B().a()) );
  template<typename B> static char test(...);
  static bool constexpr hasIt = std::is_same<decltype(AHelper::test<T>(0)), int>::value;
};

template<typename T, bool> struct AGetter {
  inline static float get_a(T const& a, float xx)  {return xx;}
};

template<typename T> struct AGetter<T, true> {
  inline static float get_a(T const& a,  float xx)  {return a.a();}
};

template<typename T>
float get_a(T const& a, float xx = -1e21) {return AGetter<T, AHelper<T>::hasIt >::get_a(a,xx); }

[abdoulline]

May we get it merged for Igor to proceed with making Method 3 permanently running (as Method 0 does) ?

[davidlange6]

+1