Changed static to static const to avoid complaints from the thread-safety checker #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ktf this is a technical change only. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X. Changed static to static const to avoid complaints from the thread-safety checker It involves the following packages: DataFormats/L1GlobalTrigger @smuzaffar, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
ktf
added a commit
that referenced
this pull request
Oct 22, 2013
Thread safety fixes -- Changed static to static const to avoid complaints from the thread-safety checker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Thread-safety checker looks for uses of non-const statics in the code and complains when they are found. This code had such statics, however the are only ever used to read and never to change. Therefore it was perfectly safe to change them to 'const static'.