Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting modifications from 74 (PR #10844): "Debugged beam-spot monitor based on pixel vertices" #11256

Merged
merged 1 commit into from Sep 17, 2015
Merged

Conversation

dinardo
Copy link
Contributor

@dinardo dinardo commented Sep 15, 2015

I've ported the code from 74.
Please discard then the pull request #10918.
Many thanks,

  • Mauro.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dinardo (Mauro) for CMSSW_7_6_X.

Porting modifications from 74

It involves the following packages:

DQM/BeamMonitor
DQM/Integration

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Sep 15, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@deguio
Copy link
Contributor

deguio commented Sep 15, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@dinardo - please change to a descriptive title to this PR for the release notes. Thanks!

@dinardo dinardo changed the title Porting modifications from 74 Porting modifications from 74 after rebase Sep 16, 2015
@dinardo
Copy link
Contributor Author

dinardo commented Sep 16, 2015

Hi,
ok done.

  • Mauro.

@davidlange6
Copy link
Contributor

from the title I have no idea what has changed in the PR (other than its port of one of the other 10k PRs we have). Could you try again. Thanks @dinardo

@dinardo dinardo changed the title Porting modifications from 74 after rebase Porting modifications from 74 (PR #10844): "Debugged beam-spot monitor based on pixel vertices" Sep 16, 2015
@dinardo
Copy link
Contributor Author

dinardo commented Sep 16, 2015

Hi David,
this PR is tightly linked to the pull request #10844
In fact it's identical ! I've simply pulled the same files
in 74, 75 and 76.
Therefore the right title should be the same as #10844,
i.e. "Debugged beam-spot monitor based on pixel vertices"
Cheers,

  • Mauro.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 17, 2015
Porting modifications from 74 (PR #10844): "Debugged beam-spot monitor based on pixel vertices"
@cmsbuild cmsbuild merged commit 09d2d6f into cms-sw:CMSSW_7_6_X Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants