Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't pass puppi NaNs to pseudojet methods #11267

Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Sep 16, 2015

fix crash reported in https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1385.html
[and likely similar ones observed with the previous versions in 0T in the past]

tested in CMSSW_7_4_12 with the setup reported in the HN:

  • crash was reproduced (faster with a skip of 2500 events) in the original release
  • crash is gone with the fix (the pt=0 and y=99 didn't reappear as an issue downstream)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_4_X.

don't pass puppi NaNs to pseudojet methods

It involves the following packages:

CommonTools/PileupAlgos

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@ahinzmann, @jdolen, @rappoccio this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor Author

slava77 commented Sep 16, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@slava77 - is is known why we have nans in the first place?

davidlange6 added a commit that referenced this pull request Sep 16, 2015
…iner

don't pass puppi NaNs to pseudojet methods
@davidlange6 davidlange6 merged commit 2fa2ca2 into cms-sw:CMSSW_7_4_X Sep 16, 2015
@slava77
Copy link
Contributor Author

slava77 commented Sep 16, 2015

I can take a look. (I don't know)
On Sep 16, 2015 4:00 AM, "David Lange" notifications@github.com wrote:

@slava77 https://github.com/slava77 - is is known why we have nans in
the first place?


Reply to this email directly or view it on GitHub
#11267 (comment).

davidlange6 added a commit that referenced this pull request Sep 17, 2015
…gn591/crashA-PuppiContainer

don't pass puppi NaNs to pseudojet methods (port of #11267 to 75X)
@slava77
Copy link
Contributor Author

slava77 commented Sep 17, 2015

+1

(just for the record that there are no diffs in jenkins tests, as expected)

@slava77
Copy link
Contributor Author

slava77 commented Sep 17, 2015

as for the origins: there is a follow up #11302, which still needs an extra look from Michalis

davidlange6 added a commit that referenced this pull request Sep 20, 2015
…A-PuppiContainer

don't pass puppi NaNs to pseudojet methods (port of #11267 to 76X)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants