Fix statics DataFormats/EcalDet

[Dr15Jones]

Fixed items found by thread-safety checkers. This includes
-changing 'static' to 'const static' where appropriate
-using std::call_once to safely fill a static array that is only used in a 'const' way after it is filled.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Fix statics DataFormats/EcalDet

It involves the following packages:

DataFormats/EcalDetId

@smuzaffar, @civanch, @Dr15Jones, @ianna, @mdhildreth, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[nclopezo]

-1
I found an error when building:

In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-23-0200/src/CondFormats/EcalObjects/interface/EcalCondObjectContainer.h:4,
                 from src/CondFormats/EcalObjects/src/classes.h:4:
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-23-0200/src/DataFormats/EcalDetId/interface/EcalContainer.h: In member function 'T& EcalContainer::operator[](uint32_t)':
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-23-0200/src/DataFormats/EcalDetId/interface/EcalContainer.h:46: error: a function-definition is not allowed here before '{' token
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-23-0200/src/DataFormats/EcalDetId/interface/EcalContainer.h:48: error: 'dummy' was not declared in this scope
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-23-0200/src/DataFormats/EcalDetId/interface/EcalContainer.h: In member function 'const T& EcalContainer::operator[](uint32_t) const':
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-23-0200/src/DataFormats/EcalDetId/interface/EcalContainer.h:74: error: a function-definition is not allowed here before '{' token
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-23-0200/src/DataFormats/EcalDetId/interface/EcalContainer.h:76: error: 'dummy' was not declared in this scope

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/970/summary.html

[cmsbuild]

Pull request #1139 was updated. @smuzaffar, @civanch, @Dr15Jones, @ianna, @mdhildreth, @nclopezo, @ktf can you please check and sign again.

[nclopezo]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/985/summary.html

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?