Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mayConsume to conditional consumes in PATJetProducer #11401

Merged

Conversation

Dr15Jones
Copy link
Contributor

Changed from a mayConsume to a conditionally called consumes since
the call to getByToken is governed by another parameter known at
configuration time. Only if the other parameter is true will we
call consumes.

Changed from a mayConsume to a conditionally called consumes since
the call to getByToken is governed by another parameter known at
configuration time. Only if the other parameter is true will we
call consumes.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Change mayConsume to conditional consumes in PATJetProducer

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Sep 24, 2015
…er_7_6

Change mayConsume to conditional consumes in PATJetProducer
@davidlange6 davidlange6 merged commit b7ffe63 into cms-sw:CMSSW_7_6_X Sep 24, 2015
@Dr15Jones Dr15Jones deleted the fixMayConsumesInPATJetProducer_7_6 branch September 24, 2015 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants