Position calc fix

[argiro]

Fix sporadic crash in clustering

[cmsbuild]

A new Pull Request was created by @argiro for CMSSW_7_4_X.

Position calc fix

It involves the following packages:

RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification
RecoParticleFlow/PFClusterProducer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @Sam-Harper, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[lgray]

@argiro can you do the following (to get rid of things from the patchX branch of 74):

git checkout PositionCalcFix
git fetch official-cmssw CMSSW_7_4_X:CMSSW_7_4_X
git rebase -i --onto CMSSW_7_4_X PositionCalcFix~1 PositionCalcFix
git push my-cmssw PositionCalcFix -f

Thanks!

[argiro]

I submitted (mistake) PRs for both CMSSW_7_4_12_patchX #11414 and CMSSW_7_4_X, should I just cancel the former ?

On 22 Sep 2015, at 15:06, Lindsey Gray notifications@github.com wrote:

@argiro can you do the following (to get rid of things from the patchX branch of 74):

git checkout PositionCalcFix
git fetch official-cmssw CMSSW_7_4_X:CMSSW_7_4_X
git rebase -i --onto CMSSW_7_4_X PositionCalcFix~1 PositionCalcFix
git push my-cmssw PositionCalcFix -f

Thanks!

—
Reply to this email directly or view it on GitHub.

[davidlange6]

I think we need both - if one becomes irrelevant we will close it.

On Sep 22, 2015, at 3:10 PM, argiro notifications@github.com wrote:

I submitted (mistake) PRs for both CMSSW_7_4_12_patchX #11414 and CMSSW_7_4_X, should I just cancel the former ?

On 22 Sep 2015, at 15:06, Lindsey Gray notifications@github.com wrote:

@argiro can you do the following (to get rid of things from the patchX branch of 74):

git checkout PositionCalcFix
git fetch official-cmssw CMSSW_7_4_X:CMSSW_7_4_X
git rebase -i --onto CMSSW_7_4_X PositionCalcFix~1 PositionCalcFix
git push my-cmssw PositionCalcFix -f

Thanks!

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

[argiro]

done (followed instructions below)

Stefano

On 22 Sep 2015, at 15:11, David Lange notifications@github.com wrote:

I think we need both - if one becomes irrelevant we will close it.

On Sep 22, 2015, at 3:10 PM, argiro notifications@github.com wrote:

I submitted (mistake) PRs for both CMSSW_7_4_12_patchX #11414 and CMSSW_7_4_X, should I just cancel the former ?

On 22 Sep 2015, at 15:06, Lindsey Gray notifications@github.com wrote:

@argiro can you do the following (to get rid of things from the patchX branch of 74):

git checkout PositionCalcFix
git fetch official-cmssw CMSSW_7_4_X:CMSSW_7_4_X
git rebase -i --onto CMSSW_7_4_X PositionCalcFix~1 PositionCalcFix
git push my-cmssw PositionCalcFix -f

Thanks!

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

[cmsbuild]

Pull request #11415 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

[lgray]

@cmsbuild please test

@argiro Thanks!

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: a0d2b31
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11415/8263/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11415/8263/summary.html

[cvuosalo]

+1

For #11415 a0d2b31

Fixing buggy code related to the ECAL 2D position that was causing sporadic crashes. There should be no change in monitored quantities.

The code change fixes incorrect code. Jenkins tests against baseline CMSSW_7_4_X_2015-09-21-2300 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1