[LHERunInfo] comment out the statistics printout

[syuvivida]

Commented out the statistics printout of LHERunInfo since it is misleading.
Users should use the information from GenXSecAnalyzer.

[cmsbuild]

A new Pull Request was created by @syuvivida for CMSSW_7_6_X.

[LHERunInfo] comment out the statistics printout

It involves the following packages:

GeneratorInterface/LHEInterface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[covarell]

@bendavid @govoni are we sure we want to delete this?
It seems someone has put quite some effort in defining a correct output... and the discrepancy found by Steve seems to affect only LHEs with a very small number of events we seldom deal with...

[bendavid]

I was thinking more to gracefully silence/avoid the printout for normal running but still have the code there for debugging.

In principle all of this logic (and much of the code) should now be duplicated in the GenXSecAnalyzer

[syuvivida]

Hello,
Do you guys prefer that I simply disable all the hadronizer filters that calls this statistics function,
for example, HadronizerFilter, etc ...
while still keeping the LHERunInfo::statistics funcion non-empty?

Eiko

[bendavid]

Does the statistics() function do anything aside from the printout?

[syuvivida]

only printout

[syuvivida]

@bendavid @covarell @govoni
I will be offline from tomorrow until Sep 28. If we make a decision today, I could re-commit today.

Eiko

[covarell]

I think the best solution would be to keep all the code but change all the cout into a logging level which is not activated by the normal settings of the MessageLogger (e.g. LogDebug)

[syuvivida]

@covarell
I have replaced all cout messages inside LHERunInfo::statistics with LogDebug and also tested the new code by turning on LogDebug.

[cmsbuild]

Pull request #11420 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please check and sign again.

[covarell]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: 86ad174
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11420/8395/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11420/8395/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1