Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PU jet ID config used for MVAmet #11428

Merged
merged 1 commit into from Oct 10, 2015

Conversation

ahinzmann
Copy link
Contributor

Fixes the problem in the PU jet ID config, to be able to run on the new MiniAOD samples, reported in this thread:
https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3413/1/1.html

@ahinzmann
Copy link
Contributor Author

This PR is for an analysis release, such that analyzers can run MVAmet on the new MiniAODs.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for CMSSW_7_4_X.

Fix PU jet ID config used for MVAmet

It involves the following packages:

RecoMET/METPUSubtraction

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 23, 2015

@ahinzmann are there PRs for 75X and 76X? (there is no auto-forward porting from 74X)

jshlee added a commit to jshlee/CATTools that referenced this pull request Sep 23, 2015
jshlee added a commit to vallot/CATTools that referenced this pull request Sep 23, 2015
@ahinzmann
Copy link
Contributor Author

@slava77 thanks for the message. I was indeed hoping for auto-forward port, but I'll do the 75 and 76 PR now.

@slava77
Copy link
Contributor

slava77 commented Sep 23, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11428 cc499ec

Adding a missing parameter for PU jet ID config, for use by analysts. There should be no change in RECO.

Jenkins tests against baseline CMSSW_7_4_X_2015-09-22-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 10, 2015
Fix PU jet ID config used for MVAmet
@cmsbuild cmsbuild merged commit 8a2df5d into cms-sw:CMSSW_7_4_X Oct 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants