Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSC Halo filter: adding classes for nex filter #11528

Merged
merged 3 commits into from Sep 30, 2015

Conversation

lathomas
Copy link
Contributor

So far, the results of the two new working points of the filter were only stored as methods in CSCHaloData.
I have now created two EDFilters for each of them and added them to the list of metFilters.
I also added them to the lists of flags in MINIAOD.
Let me know if there's any problem !

Thanks a lot,

Laurent

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lathomas for CMSSW_7_6_X.

CSC Halo filter: adding classes for nex filter

It involves the following packages:

PhysicsTools/PatAlgos
RecoMET/METFilters

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

#include "FWCore/ParameterSet/interface/ParameterSet.h"
#include "DataFormats/METReco/interface/BeamHaloSummary.h"

class CSCTightHalo2015Filter : public edm::EDFilter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a edm::stream or edm::global (the latter fits better)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slava77 Done. I have updated the two new classes and the original one as well.

@lathomas
Copy link
Contributor Author

@slava77 If you are happy with the changes, can you trigger the tests?
Thanks a lot !

@cmsbuild
Copy link
Contributor

Pull request #11528 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Sep 29, 2015

@cmsbuild please test

@lathomas
this will need to be signed by AT
I have just made some quick suggestions to speed up the process

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Sep 30, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 30, 2015
CSC Halo filter: adding classes for nex filter
@cmsbuild cmsbuild merged commit 2febd3b into cms-sw:CMSSW_7_6_X Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants