Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksum parameter cfi export (75X) #11536

Merged
merged 1 commit into from Oct 12, 2015

Conversation

smorovic
Copy link
Contributor

CRC32 is checked by default, however parameter to control this is not exported.

We need a way to switch this off in heavy ion test setup, so two changes are provided:

  • export of the parameter (for the new template)
  • reuse adler32 setting as default (as we replaced adler32 with crc32c, for existing templates).

Also, two other not previously exported parameters were added to cfi files, and input source parameter defaults were changed to defaults used in production.

Backport of #11535

…tion

*updates to CFI files (export CRC32 checksum setting,  empty LS mode setting
be enabled)
*inherit CRC32C checksum setting from verifyAdler32 as default value
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_5_X.

Checksum parameter cfi export (75X)

It involves the following packages:

EventFilter/Utilities

@mommsen, @cvuosalo, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mommsen
Copy link
Contributor

mommsen commented Sep 29, 2015

+1

@cvuosalo
Copy link
Contributor

+1

For #11536 6a5ad2f

For Heavy Ions, exporting checksum parameter so it can be toggled as necessary. There should be no change in monitored quantities. #11535 is the 76X version of this PR, and it has already been approved by Reco.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-09-27-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 12, 2015
@cmsbuild cmsbuild merged commit 741f882 into cms-sw:CMSSW_7_5_X Oct 12, 2015
@smorovic smorovic deleted the add-checksum-param-75X branch November 13, 2015 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants