Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FED Occupancy plot a TProfile #11601

Merged
merged 2 commits into from Oct 8, 2015
Merged

Make FED Occupancy plot a TProfile #11601

merged 2 commits into from Oct 8, 2015

Conversation

fioriNTU
Copy link
Contributor

@fioriNTU fioriNTU commented Oct 1, 2015

Move to TProfile the Pixel FED occupancy plot and remove some commented code

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

A new Pull Request was created by @fioriNTU for CMSSW_7_6_X.

Make FED Occupancy plot a TProfile

It involves the following packages:

DQM/SiPixelMonitorDigi

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Oct 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

Pull request #11601 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Oct 7, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

-1

Tested at: 0893d23
I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:50nsGRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_50nsGRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_50ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_50nsGRun_DATA.root --fileout file:RelVal_Raw_50nsGRun_DATA_HLT_RECO.root : FAILED - time: date Wed Oct 7 13:44:26 2015-date Wed Oct 7 13:33:44 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Wed Oct 7 14:05:16 2015-date Wed Oct 7 13:57:41 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Wed Oct 7 14:16:00 2015-date Wed Oct 7 14:07:28 2015 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11601/8666/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Oct 8, 2015
Make FED Occupancy plot a TProfile
@davidlange6 davidlange6 merged commit c42e568 into cms-sw:CMSSW_7_6_X Oct 8, 2015
@fioriNTU
Copy link
Contributor Author

fioriNTU commented Dec 8, 2015

@davidlange6 can someone restart the approval of this, the errors in the test are not depending by this PR

@smuzaffar
Copy link
Contributor

@fioriNTU , this has been merged since 8th of OCT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants