Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy muonDetIdAssociator customisation changes to eras #11654

Merged

Conversation

mark-grimes
Copy link

Pull request #11248 made a change that takes the Run 2 eras out of synch. This PR adds the change to the Run 2 eras as well.

The divergence was seen in
http://grimes.web.cern.ch/grimes/eraProcessDiffs/processDiffs-7_6_X_2015-10-05-1838-PR11466.html

With this PR, post LS1 customs should be functionally equivalent to Run 2 eras, a check on a smaller subset of workflows is at
http://grimes.web.cern.ch/grimes/eraProcessDiffs/processDiffs-7_6_X_2015-10-05-2300-mark-grimes_copyChangesIn11248ToEras-PR11466.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_6_X.

Copy muonDetIdAssociator customisation changes to eras

It involves the following packages:

TrackingTools/TrackAssociator

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @bellan, @rovere, @istaslis, @gpetruc, @cerati, @trocino, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 6, 2015

@cmsbuild please test
@mark-grimes is there an era-based matrix workflow (just not to modify cmsDriver commands inside the workflows)?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

The tests are being triggered in jenkins.

@mark-grimes
Copy link
Author

@slava77 No there's not (unless I'm very much mistaken).

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

-1

Tested at: 31dc368
I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11654/8643/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

davidlange6 added a commit that referenced this pull request Oct 7, 2015
Copy muonDetIdAssociator customisation changes to eras
@davidlange6 davidlange6 merged commit f56b7b1 into cms-sw:CMSSW_7_6_X Oct 7, 2015
@mark-grimes mark-grimes deleted the copyChangesIn11248ToEras branch October 7, 2015 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants