Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed private_public in unit test #11659

Merged
merged 1 commit into from Oct 7, 2015

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Oct 6, 2015

Removed '#define private public' from geometry unit test.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_6_X.

removed private_public in unit test

It involves the following packages:

SimG4Core/Geometry

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor Author

civanch commented Oct 6, 2015

please test

@civanch
Copy link
Contributor Author

civanch commented Oct 6, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 7, 2015
removed private_public in unit test
@cmsbuild cmsbuild merged commit 327a5cb into cms-sw:CMSSW_7_6_X Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants