Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stacktrace handler to timeout. #11662

Merged
merged 1 commit into from Oct 7, 2015

Conversation

bbockelm
Copy link
Contributor

@bbockelm bbockelm commented Oct 6, 2015

This corrects a few issues:

  • Stacktrace handler thread will set the SIGABRT and friends handler
    to SIG_DFL. Avoids a potential deadlock.
  • Primary signal handler will timeout after 5 minutes of waiting for
    the stacktrace handler thread to return (timeout hardcoded for now).
  • Do NOT call execv: libsnoopy at CERN replaces the async-signal-safe
    POSIX function with a non-async-signal-safe variant which can cause
    deadlocks. Instead, invoke the syscall directly (only on Linux).

This corrects a few issues:
- Stacktrace handler thread will set the SIGABRT and friends handler
  to SIG_DFL.  Avoids a potential deadlock.
- Primary signal handler will timeout after 5 minutes of waiting for
  the stacktrace handler thread to return (timeout hardcoded for now).
- Do NOT call execv: libsnoopy at CERN replaces the async-signal-safe
  POSIX function with a non-async-signal-safe variant which can cause
  deadlocks.  Instead, invoke the syscall directly (only on Linux).
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_7_6_X.

Allow stacktrace handler to timeout.

It involves the following packages:

FWCore/Services

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@bbockelm
Copy link
Contributor Author

bbockelm commented Oct 7, 2015

@Dr15Jones - I assume a backport is reasonable for 7.4 and 7.5 if this passes IBs with flying colors?

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 7, 2015
@cmsbuild cmsbuild merged commit b3bab80 into cms-sw:CMSSW_7_6_X Oct 7, 2015
@Dr15Jones
Copy link
Contributor

@bbockelm Which ever releases we switch out the ROOT handler for your new one we will need back porch this change to as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants