Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQM/PixelLumi: definite static const int members #11721

Merged
merged 1 commit into from Oct 15, 2015
Merged

DQM/PixelLumi: definite static const int members #11721

merged 1 commit into from Oct 15, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Oct 10, 2015

The patch resolves issue with Clang compiler.

N3690 (should be C++11 standard), 9.4.2/3

...
The member shall still be defined in a namespace scope if it
is odr-used (3.2) in the program and the namespace scope definition
shall not contain an initializer.

9.4.2/4 talks about how const static data members are being handled.

Also standard says that no diagnostic is required by compiler.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

DQM/PixelLumi: definite static const int members
be2235f 
The patch resolves issue with Clang compiler.

N3690 (should be C++11 standard), 9.4.2/3

    ...
    The member shall still be defined in a namespace scope if it
    is odr-used (3.2) in the program and the namespace scope definition
    shall not contain an initializer.

9.4.2/4 talks about how `const static` data members are being handled.

Also standard says that no diagnostic is required by compiler.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 10, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

DQM/PixelLumi: definite static const int members

It involves the following packages:

DQM/PixelLumi

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

+1
Tested at: be2235f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11721/8743/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11721/8743/summary.html

@deguio
Copy link
Contributor

deguio commented Oct 14, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Oct 15, 2015
@davidlange6
Merge pull request #11721 from davidlt/DQM-PixelLumi-clang-fix
7c26e67 
DQM/PixelLumi: definite static const int members
@davidlange6 davidlange6 merged commit 7c26e67 into cms-sw:CMSSW_7_6_X Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidlt @cmsbuild @deguio @davidlange6