Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UB by settting firstStep in AnnealingGhostTrackFitter #11734

Merged

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Oct 12, 2015

Resolved undefined behavior triggered in AnnealingGhostTrackFitter:

RecoVertex/GhostTrackFitter/interface/AnnealingGhostTrackFitter.h:22:27:
runtime error: load of value 105, which is not a valid value for type
'bool'

The class has user provided ctor, but firstStep is not explicitly
initialized thus it's default-initialized to indeterminate value.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Resolved undefined behavior triggered in `AnnealingGhostTrackFitter`:

    RecoVertex/GhostTrackFitter/interface/AnnealingGhostTrackFitter.h:22:27:
    runtime error: load of value 105, which is not a valid value for type
    'bool'

The class has user provided ctor, but `firstStep` is not explicitly
initialized thus it's default-initialized to indeterminate value.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

Fix UB by settting firstStep in AnnealingGhostTrackFitter

It involves the following packages:

RecoVertex/GhostTrackFitter

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlt
Copy link
Contributor Author

davidlt commented Oct 12, 2015

This happens in a wide range of workflows, e.g. 4.76, 134.706, 4000.0, 50200.0. Happens only once per step (incl. step2, step3).

@slava77
Copy link
Contributor

slava77 commented Oct 13, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8771/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11734 c5bc573

Small fix to initialize an uninitialized data member in the AnnealingGhostTrackFitter.

The code fix is satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-10-12-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Oct 15, 2015
Fix UB by settting firstStep in AnnealingGhostTrackFitter
@davidlange6 davidlange6 merged commit 12732da into cms-sw:CMSSW_7_6_X Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants