New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UB by settting firstStep in AnnealingGhostTrackFitter #11734
Fix UB by settting firstStep in AnnealingGhostTrackFitter #11734
Conversation
Resolved undefined behavior triggered in `AnnealingGhostTrackFitter`: RecoVertex/GhostTrackFitter/interface/AnnealingGhostTrackFitter.h:22:27: runtime error: load of value 105, which is not a valid value for type 'bool' The class has user provided ctor, but `firstStep` is not explicitly initialized thus it's default-initialized to indeterminate value. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for CMSSW_7_6_X. Fix UB by settting firstStep in AnnealingGhostTrackFitter It involves the following packages: RecoVertex/GhostTrackFitter @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
This happens in a wide range of workflows, e.g. 4.76, 134.706, 4000.0, 50200.0. Happens only once per step (incl. step2, step3). |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Fix UB by settting firstStep in AnnealingGhostTrackFitter
Resolved undefined behavior triggered in
AnnealingGhostTrackFitter
:The class has user provided ctor, but
firstStep
is not explicitlyinitialized thus it's default-initialized to indeterminate value.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch