EGM ID Updates from recipes (76X) #11738

lgray · 2015-10-12T22:01:02Z

This PR is brings CMSSW in line with the latest EGM recipes.

New IDs:

Triggering electron MVA ID for 25ns and 50ns
V2 of cutbased electron ID for Spring15, HLT safe at "tight" working point

Bugfix:

Photon cutbased ID was applying linear scaling in the endcaps for neutral had iso, it should have been exponential.

Externals PR is here: cms-data/RecoEgamma-ElectronIdentification#6
Please wait until this is in an IB before testing.

@ikrav

…an HLT

…VA V1 for both 50ns and 25ns of Spring15

…gering MVA

…ial, a linear scaling was used for neutral hadron isolation cut for the endcap. Fixed now.

cmsbuild · 2015-10-12T22:01:18Z

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_6_X.

EGM ID Updates from recipes (76X)

It involves the following packages:

PhysicsTools/PatAlgos
RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @Sam-Harper, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

slava77 · 2015-10-13T12:39:58Z

@lgray here and in your other two PRs I'm not going to trigger tests, assuming you will detect when the IB with the externals show up

lgray · 2015-10-13T12:44:16Z

@slava77 Yes, I'll take care of starting the tests.

lgray · 2015-10-14T07:45:41Z

@cmsbuild please test

cmsbuild · 2015-10-14T07:46:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8804/console

cmsbuild · 2015-10-14T07:46:28Z

Pull request #11738 was updated. @cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please check and sign again.

cmsbuild · 2015-10-14T08:44:23Z

-1
Tested at: 4215ca0
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11738/8804/summary.html

lgray · 2015-10-14T08:47:28Z

Errors seem to be with runTheMatrix.py itself:

Deprecated, please use -l limited
processing relval_standard
ERROR in Step
overwritting RunHLTPhy2015C not allowed

and then it quits...

Will wait for the IBs to be fixed before proceeding.
Luckily VID unit tests are OK!

smuzaffar · 2015-10-14T20:08:26Z

please test

cmsbuild · 2015-10-14T20:11:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8870/console

cmsbuild · 2015-10-14T23:20:16Z

-1
Tested at: 4215ca0
When I ran the RelVals I found an error in the following worklfows:
4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11738/8870/summary.html

lgray · 2015-10-15T06:26:50Z

@cmsbuild please test

cmsbuild · 2015-10-15T06:31:29Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8885/console

cmsbuild · 2015-10-15T06:31:31Z

Pull request #11738 was updated. @cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please check and sign again.

cmsbuild · 2015-10-15T08:26:06Z

+1
Tested at: 2f1cf60
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11738/8885/summary.html

cmsbuild · 2015-10-15T09:24:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11738/8885/summary.html

slava77 · 2015-10-19T21:38:04Z

RecoEgamma/ElectronIdentification/plugins/ElectronMVAEstimatorRun2Spring15Trig.cc

+								    theBeamSpot->position());
+  double vertexFitProbability = -1.; 
+  if(!conv_ref.isNull()) {
+    const reco::Vertex &vtx = conv_ref.get()->conversionVertex(); if (vtx.isValid()) {


new line in front of the "if" would be nice

slava77 · 2015-10-20T03:46:21Z

+1

for #11738 2f1cf60

code changes are in line with the PR description
- minor code review comments can be addressed separately
jenkins tests pass and comparisons with baseline show no differences (the only changes expected are in ID variables [user floats ] in the slimmedPhotons and electrons)
local tests show
- changes in timing of electronMVAValueMapProducer increasing by almost x2 (still under 1ms/evt): expected since new variables are computed for electrons, and the same count with similar complexity for photons
- event size changes show differences only in miniAOD, most visible in the slimmedElectrons (1% increase in the branch size on 200 events from DoubleEG PD)

EGM ID Updates from recipes (76X)

ikrav and others added 6 commits October 12, 2015 23:38

New version of this ID, WP Tight EB is revised only, to be tighter th…

2239b86

…an HLT

First implementation of the triggering electron MVA for Spring15 in C++

2b14c11

Python configuration and addition to VID of the triggering electron M…

86e66e6

…VA V1 for both 50ns and 25ns of Spring15

Fixed the wp90 and wp80 example cut values for the 50ns electron trig…

165c38f

…gering MVA

A fix of 50ns cut-based photon ID: by mistake instead of the exponent…

f1e02b4

…ial, a linear scaling was used for neutral hadron isolation cut for the endcap. Fixed now.

update EGM IDs and embed new MVA values

6b714a6

cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 12, 2015

cmsbuild added reconstruction-pending analysis-pending pending-signatures tests-pending orp-pending comparison-pending labels Oct 12, 2015

This was referenced Oct 12, 2015

EGM ID Updates from recipes (75X) #11739

Closed

EGM ID Updates from recipes (74X) #11740

Merged

update electron unit tests

4215ca0

cmsbuild added tests-started and removed tests-pending labels Oct 14, 2015

cmsbuild added tests-rejected and removed tests-started labels Oct 14, 2015

cmsbuild added tests-pending tests-started and removed tests-rejected tests-pending labels Oct 14, 2015

cmsbuild added tests-rejected and removed tests-started labels Oct 14, 2015

fix up python

2f1cf60

cmsbuild added tests-pending and removed tests-rejected labels Oct 15, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 15, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 15, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 15, 2015

cmsbuild mentioned this pull request Oct 19, 2015

EGM ID Updates from recipes (76X) #11927

Merged

slava77 reviewed Oct 19, 2015
View reviewed changes

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 20, 2015

davidlange6 added a commit that referenced this pull request Oct 20, 2015

Merge pull request #11738 from lgray/egm_id_7.4.12v1_port_76X

3e46e44

EGM ID Updates from recipes (76X)

davidlange6 merged commit 3e46e44 into cms-sw:CMSSW_7_6_X Oct 20, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EGM ID Updates from recipes (76X) #11738

EGM ID Updates from recipes (76X) #11738

lgray commented Oct 12, 2015

cmsbuild commented Oct 12, 2015

slava77 commented Oct 13, 2015

lgray commented Oct 13, 2015

lgray commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

lgray commented Oct 14, 2015

smuzaffar commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

lgray commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

slava77 Oct 19, 2015

slava77 commented Oct 20, 2015

EGM ID Updates from recipes (76X) #11738

EGM ID Updates from recipes (76X) #11738

Conversation

lgray commented Oct 12, 2015

cmsbuild commented Oct 12, 2015

slava77 commented Oct 13, 2015

lgray commented Oct 13, 2015

lgray commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

lgray commented Oct 14, 2015

smuzaffar commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

lgray commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

slava77 Oct 19, 2015

Choose a reason for hiding this comment

slava77 commented Oct 20, 2015