Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EGM ID Updates from recipes (74X) #11740

Merged
merged 6 commits into from Nov 1, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Oct 12, 2015

Backport of #11738.

MiniAOD embedding is not updated to the latest version in this backport to keep MiniAOD in line with 7_4_14 reMiniAOD campaign.

Externals PR is here: cms-data/RecoEgamma-ElectronIdentification#6
Please wait until this is in an IB before testing.

@ikrav

@lgray lgray changed the title Egm id 7.4.12 for pr EGM ID Updates from recipes (74X) Oct 12, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Oct 12, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_4_X.

EGM ID Updates from recipes (74X)

It involves the following packages:

RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor Author

lgray commented Oct 15, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8887/console

@cmsbuild
Copy link
Contributor

Pull request #11740 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 21, 2015

+1

for #11740 2ba0e1f

  • changes are in line with the PR description: the MVAs are running , but are not saved in miniAOD
  • jenkins tests pass and comparisons with baseline show no differences
  • tested locally in CMSSW_7_4_X_2015-10-20-2300: no differences are confirmed looking at miniAOD product sizes (electronMVAValueMapProducer producer take up ~0.5ms/evt more time, which is OK; although dead products/destinations are not a particularly good thing)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6 davidlange6 modified the milestones: Next CMSSW_7_4_X, Next CMSSW_7_6_X Oct 24, 2015
@cmsbuild cmsbuild modified the milestones: Next CMSSW_7_4_X, Next CMSSW_7_6_X Oct 24, 2015
@lgray
Copy link
Contributor Author

lgray commented Oct 28, 2015

@davidlange6 ping... just to make sure.

davidlange6 added a commit that referenced this pull request Nov 1, 2015
EGM ID Updates from recipes (74X)
@davidlange6 davidlange6 merged commit 247a55f into cms-sw:CMSSW_7_4_X Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants