Adding HBHENegativeNoise bit to HcalRecHitFlagsToBeExcluded - 76X

[dertexaner]

Adding HBHENegativeNoise bit to the HcalRecHitFlagsToBeExcluded list, so that NEF related quantities (nnegativenoise_, negativenoisee_, negativenoiseet_) are correctly computed in HcalNoiseInfoProducer once the NEF severity level is raised as in PR #11667 .
Otherwise they will always compute to be zero.
(please see: http://cmslxr.fnal.gov/lxr/source/RecoMET/METProducers/src/HcalNoiseInfoProducer.cc?v=CMSSW_7_6_0_pre2#0574)

[cmsbuild]

A new Pull Request was created by @dertexaner for CMSSW_7_6_X.

Adding HBHENegativeNoise bit to HcalRecHitFlagsToBeExcluded - 76X

It involves the following packages:

RecoMET/METProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8782/console

[cmsbuild]

-1

Tested at: 9bcc923
I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11751/8782/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11751/8782/summary.html

[dertexaner]

Any ideas for the errors here? It seems to complain about "particleFlowClusterECAL" in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11751/8782/unitTests.log:

Begin processing the 1st record. Run 1, Event 1, LumiSection 1 at 13-Oct-2015 14:52:14.635 CEST
----- Begin Fatal Exception 13-Oct-2015 14:52:14 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 1 event: 1
[1] Running path 'p'
[2] Calling event method for module CorrectedECALPFClusterProducer/'particleFlowClusterECAL'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: unsigned int
Looking for module label: bunchSpacingProducer
Looking for productInstanceName:

[slava77]

the error in testRecoMETMETProducers can be ignored for the purpose of this PR

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8857/console

[cmsbuild]

-1

Tested at: 9bcc923
I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11751/8857/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11751/8857/summary.html

[slava77]

+1

for #11751 9bcc923

• changes are in line with the description
• jenkins tests pass and show small differences in noise filter status values (only 1000.0 workflow has differences)
• tested locally in CMSSW_7_6_0_pre7 with 2015 2015B and 2015C workflows included: there is essentially no change in 10K 2015C DoubleEG dataset; comparisons in 2015C MET PD shows the most significant differences (as expected in 25ns in a MET PD)
  • there are no changes in "regular" reco products, only in the noise info and in variables or plots which require noise cleaning
    raw filter flags in 134.805:
    
    noise rates increase in HB
    
    

these are clearly noise-like

plots for negative noise are now filled

About 5% more events are cleaned inclusively

Looking at dijet events (more balanced and physics like) have a smaller change in cleaning

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1