Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use improvements and fixes from 76X #11775

Merged
merged 3 commits into from Oct 15, 2015

Conversation

mkirsano
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for CMSSW_7_1_X.

Use improvements and fixes from 76X

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mkirsano
Copy link
Contributor Author

Incompatible with pythia8 205. To be done together with pythia8 upgrade to 212

@mkirsano
Copy link
Contributor Author

To be used together with cmsdist #1896

@cmsbuild
Copy link
Contributor

Pull request #11775 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please check and sign again.

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8805/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: daf7689
I found an error when building:

>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_1_X_2015-10-13-2300/src/GeneratorInterface/Pythia8Interface/plugins/LHAupLesHouches.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_1_X_2015-10-13-2300/src/GeneratorInterface/Pythia8Interface/test/ZJetsAnalyzer.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_1_X_2015-10-13-2300/src/GeneratorInterface/Pythia8Interface/test/analyserhepmc/LeptonAnalyserHepMC.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_1_X_2015-10-13-2300/src/GeneratorInterface/Pythia8Interface/test/analyserhepmc/JetInputHepMC.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_1_X_2015-10-13-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc: In member function 'virtual bool Pythia8Hadronizer::residualDecay()':
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_1_X_2015-10-13-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:634:89: error: no matching function for call to 'HepMC::Pythia8ToHepMC::fill_next_event(std::auto_ptrPythia8::Pythia::element_type&, std::auto_ptrHepMC::GenEvent::element_type_, int, bool, HepMC::GenParticle_&)'
       result = toHepMC.fill_next_event( _(fDecayer.get()), event().get(), -1, true, part);
                                                                                         ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_1_X_2015-10-13-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:634:89: note: candidates are:
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_1_X_2015-10-13-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:12:0:
/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc481/external/pythia8/205-ddibom2/include/Pythia8Plugins/HepMC2.h:38:8: note: bool HepMC::Pythia8ToHepMC::fill_next_event(Pythia8::Pythia&, HepMC::GenEvent_, int)


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11775/8805/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@mkirsano
Copy link
Contributor Author

Should be tested with pythia8 212, cmsdist #1896

@ghost
Copy link

ghost commented Oct 14, 2015

@mkirsano I'm testing this locally against pythia8 212. The tests have been triggered automatically following Roberto's signature: a small drawback of the current workflow.

@ghost
Copy link

ghost commented Oct 14, 2015

+1
Tested locally against cms-sw/cmsdist#1896, all usual relval passed:

4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Oct 14 11:11:35 2015-date Wed Oct 14 11:06:05 2015; exit: 0 0 0 0 0
4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Oct 14 11:28:18 2015-date Wed Oct 14 11:06:07 2015; exit: 0 0 0 0
5.1_TTbar+TTbarFS+HARVESTFS Step0-PASSED Step1-PASSED  - time date Wed Oct 14 11:10:13 2015-date Wed Oct 14 11:06:11 2015; exit: 0 0
8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Oct 14 11:12:33 2015-date Wed Oct 14 11:06:12 2015; exit: 0 0 0 0 0
9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Oct 14 11:26:24 2015-date Wed Oct 14 11:10:23 2015; exit: 0 0 0 0
25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Oct 14 11:28:18 2015-date Wed Oct 14 11:11:38 2015; exit: 0 0 0 0 0
1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Oct 14 11:20:52 2015-date Wed Oct 14 11:12:40 2015; exit: 0 0 0 0
101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL Step0-PASSED  - time date Wed Oct 14 11:23:22 2015-date Wed Oct 14 11:21:02 2015; exit: 0
25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Oct 14 11:45:00 2015-date Wed Oct 14 11:23:27 2015; exit: 0 0 0 0 0
50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVEST+MINIAODMC50 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Oct 14 11:51:38 2015-date Wed Oct 14 11:26:31 2015; exit: 0 0 0 0 0
1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Oct 14 11:38:59 2015-date Wed Oct 14 11:28:23 2015; exit: 0 0 0 0 0
1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Oct 14 11:35:42 2015-date Wed Oct 14 11:28:26 2015; exit: 0 0 0 0
1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM Step0-PASSED Step1-PASSED Step2-PASSED  - time date Wed Oct 14 11:45:32 2015-date Wed Oct 14 11:35:48 2015; exit: 0 0 0
13 12 11 10 6 tests passed, 0 0 0 0 0 failed

davidlange6 added a commit that referenced this pull request Oct 15, 2015
Use improvements and fixes from 76X
@davidlange6 davidlange6 merged commit 2b7fafe into cms-sw:CMSSW_7_1_X Oct 15, 2015
@ghost ghost added tests-approved and removed tests-rejected labels Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants