Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP code bug fix #11836

Merged
merged 1 commit into from Oct 20, 2015
Merged

EP code bug fix #11836

merged 1 commit into from Oct 20, 2015

Conversation

BetterWang
Copy link
Contributor

Same as #11835, urgent bug fix for HI run.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @BetterWang (Quan Wang) for CMSSW_7_5_X.

EP code bug fix

It involves the following packages:

RecoHI/HiEvtPlaneAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @dgulhan, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 16, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8938/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11836 83ea180

Small bug fix for Heavy Ions in HiEvtPlaneAlgos.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-10-15-2300 show no significant differences. An extended test of workflow 140.53_RunHI2011 with 70 events against baseline CMSSW_7_5_X_2015-10-15-1100 also shows no significant differences.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@slava77
Copy link
Contributor

slava77 commented Oct 18, 2015

@BetterWang
what's the effect of the fix and where does it become important?
We signed off, but mainly because there is no visible effect in the tests done.

@slava77
Copy link
Contributor

slava77 commented Oct 18, 2015

regarding #11836 (comment)
I found an answer in the 76X version of the PR
Thanks

@cvuosalo cvuosalo mentioned this pull request Oct 19, 2015
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 20, 2015
@cmsbuild cmsbuild merged commit 8de490a into cms-sw:CMSSW_7_5_X Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants