75X backport assign muon PDG id using PFMuon charge

[jhgoh]

Backport of #11838 to fix wrong pdg id assignment of muons

[cmsbuild]

A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_7_5_X.

75X backport assign muon PDG id using PFMuon charge

It involves the following packages:

RecoMuon/MuonIdentification

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @bellan, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8940/console

[cmsbuild]

+1
Tested at: 6148fca
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11841/8940/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11841/8940/summary.html

[cvuosalo]

+1

For #11841 6148fca

Fixing rare case where muon PDG ID had reversed sign. #11838 is the 76X version of this PR, and it has already been approved by Reco.

The code fix is satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-10-15-2300 show no significant differences.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1