Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed edm::LazyGetter<> related dictionaries #11846

Merged
merged 1 commit into from Oct 19, 2015

Conversation

Dr15Jones
Copy link
Contributor

The class edm::LazyGetter<> and its helper classes (edm::RefGetter<>
and edm::RegionIndex<>) are no longer in use. This pull request removes
the last dictionaries which are begin generated using those classes.

The class edm::LazyGetter<> and its helper classes (edm::RefGetter<>
and edm::RegionIndex<>) are no longer in use. This pull request removes
the last dictionaries which are begin generated using those classes.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Removed edm::LazyGetter<> related dictionaries

It involves the following packages:

DataFormats/EcalRecHit
DataFormats/HGCRecHit

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @kpedro88, @argiro, @cseez, @pfs, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8950/console

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11846 78a5d48

Clean-up of dictionaries in DataFormats to delete obsolete entries. There should be no change in run-time behavior.

Compilation is successful. Jenkins tests are not really relevant, and, in this case, they are polluted by several other PRs that show unrelated differences.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 19, 2015
Removed edm::LazyGetter<> related dictionaries
@cmsbuild cmsbuild merged commit 0001b81 into cms-sw:CMSSW_7_6_X Oct 19, 2015
@Dr15Jones Dr15Jones deleted the removeLazyGetterDicts branch October 19, 2015 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants