Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TrackingVertex->TrackingParticle links in premixing #11854

Merged
merged 1 commit into from Oct 21, 2015

Conversation

makortel
Copy link
Contributor

Validation of 760pre6 revealed that the TrackingVertex->TrackingParticle links were not working https://hypernews.cern.ch/HyperNews/CMS/get/relval/4162/15.html. This PR fixes the problem.

Tested in 760pre6 with wfs 250199+250202.0 (latter manually configured to use the output of the former for premixed pileup events). Expecting differences in all validation plots using the TrackingParticles via TrackingVertex, e.g. in primary vertex validation

  • anything vs. number of TrackingParticles and their sum(pT^2)
  • anything related to merged vertices (e.g. resolutions)

@makortel
Copy link
Contributor Author

@mdhildreth The issue in 760pre6 RelVals turned indeed out to be "no TrackingParticleRefs in TrackingVertex", and this seems to fix the issue (Refs appear, I didn't compare to classical mixing). Do you agree on the fix?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

Fix TrackingVertex->TrackingParticle links in premixing

It involves the following packages:

SimGeneral/DataMixingModule

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Oct 16, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8961/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 75a2164
When I ran the RelVals I found an error in the following worklfows:
1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11854/8961/summary.html

@civanch
Copy link
Contributor

civanch commented Oct 20, 2015

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

The jenkins tests job failed, please try again.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9075/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Oct 21, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 21, 2015
Fix TrackingVertex->TrackingParticle links in premixing
@cmsbuild cmsbuild merged commit 9c46360 into cms-sw:CMSSW_7_6_X Oct 21, 2015
@makortel makortel deleted the fixPremixTrackingVertexRef branch October 20, 2016 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants