cppcheck: some fixes for 4 modules

[serval2412]

I focused on "Prefer prefix ++/-- operators for non-primitive types"
Since I haven't found any makefile to build, I only visually checked, hope it's ok

[cmsbuild]

A new Pull Request was created by @serval2412 (Julien Nabet) for CMSSW_7_6_X.

cppcheck: some fixes for 4 modules

It involves the following packages:

AnalysisAlgos/SiStripClusterInfoProducer
AnalysisAlgos/TrackInfoProducer
AnalysisDataFormats/TrackInfo
CalibCalorimetry/CaloMiscalibTools
CalibCalorimetry/CastorCalib
CalibCalorimetry/EcalLaserAnalyzer
CalibCalorimetry/EcalTPGTools
CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins
CalibCalorimetry/HcalTPGAlgos
CalibCalorimetry/HcalTPGIO
CalibFormats/CaloObjects
CalibFormats/SiPixelObjects
CalibFormats/SiStripObjects
CalibMuon/DTCalibration
CalibMuon/RPCCalibration

@diguida, @cerminar, @monttj, @cmsbuild, @franzoni, @vadler, @mmusich, @mulhearn can you please review it and eventually sign? Thanks.
@threus, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8965/console

[cmsbuild]

-1
Tested at: 7100f26
When I ran the RelVals I found an error in the following worklfows:
135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11857/8965/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
969c956
76bfdb1
73dd545
6135678
7dc95bd
39dce0c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11857/8965/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11857/8965/git-merge-result

[serval2412]

How to take a look to the logs without registering to CERN?

[davidlt]

@serval2412 the failures are unrelated to the changes in this PR. The integration build on top of which it [this PR] was tested is broken.

[serval2412]

davidlt: thank you for your feedback, I thought I had missed something again. Hope it'll be quickly merged :-) There's still lots of reports! :-)

[davidlt]

The software is open source and our repositories are also public, thus technically you can install it and do compilation tests.

[serval2412]

Reading http://cms-sw.github.io/build-release.html, it's very different from soft like LibreOffice, Gimp and others. I'm more accustomed to something straightforward like:
git clone
./autogen.sh or ./configure
make

[serval2412]

Also, I know very few about git but if adding upstream then fetch upstream is ok, merge gives this:
merge: upstream/master - not something we can merge
I suppose there's a reason and so a solution, but it's a pity to search in docs whereas this simple way works in other projects.

[davidlt]

The above instructions are for packaging and doing a full build. There is a simpler options, but would require a VM with RHEL/Scientific Linux/CentOS 6 or 7. We have our own package and source management system (SCRAM), which generates Makefiles for all CMSSW packages before compiling. Once you install a release it's more-or-less straight forward to compile.

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10429/console

[cmsbuild]

+1
Tested at: 7100f26
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11857/10429/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11857/10429/summary.html

[mulhearn]

+1

[mmusich]

+1