Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace LinkDef file witl XML selection file in Calibration/HcalCalibAlgos #11883

Merged
merged 1 commit into from Oct 31, 2015
Merged

Replace LinkDef file witl XML selection file in Calibration/HcalCalibAlgos #11883

merged 1 commit into from Oct 31, 2015

Conversation

cmsbuild
Copy link
Contributor

It has been decided to replace LinkDef files with XML selection files.
This PR does this for the LinkDef file that was in Calibration/HcalCalibAlgos.
A reorganization of existing files was needed because XML selection files are not allowed in plugins.
LinkDef files should not be in plugins, either, but that was never enforced.
Automatically ported from CMSSW_7_6_X #11672 (original by @wmtan).

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Oct 19, 2015
@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_8_0_X.

Replace LinkDef file witl XML selection file in Calibration/HcalCalibAlgos

It involves the following packages:

Calibration/HcalCalibAlgos

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@wmtan wmtan force-pushed the ReplaceLinkDefInCalibrationHcalCalibAlgos branch from 05250ec to 6fe1040 Compare October 27, 2015 19:54
@diguida
Copy link
Contributor

diguida commented Oct 28, 2015

please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9253/console

@cmsbuild
Copy link
Contributor Author

Pull request #11883 was updated. @cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please check and sign again.

@cmsbuild
Copy link
Contributor Author

+1
Tested at: 6fe1040
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11883/9253/summary.html

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11883/9253/summary.html

@diguida
Copy link
Contributor

diguida commented Oct 30, 2015

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 31, 2015
@cmsbuild
Merge pull request #11883 from wmtan/ReplaceLinkDefInCalibrationHcalC…
d59ba8c 
…alibAlgos

Replace LinkDef file witl XML selection file in Calibration/HcalCalibAlgos
@cmsbuild cmsbuild merged commit d59ba8c into cms-sw:CMSSW_8_0_X Oct 31, 2015
@davidlange6
Copy link
Contributor

@cmsbuild, please test

@wmtan wmtan deleted the ReplaceLinkDefInCalibrationHcalCalibAlgos branch February 22, 2016 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cmsbuild @diguida @davidlange6 @wmtan