Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependency on Reflex #1191

Merged
merged 1 commit into from Oct 27, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Oct 26, 2013

The package CondCore/RegressionTest contains two unnecessary includes of Reflex headers, and the test BuildFile contains an unnecessary declaration of a link dependency on rootrflx.
This pull request removes the unnecessary includes and dependencies.
Unnecessary includes can be considered a bug, so I view this as a bug fix.

@apfeiffer1
Copy link
Contributor

+1
indeed. Thanks, Bill, for finding and fixing this !

On Sat, Oct 26, 2013 at 5:49 AM, wmtan notifications@github.com wrote:

The package CondCore/RegressionTest contains two unnecessary includes of
Reflex headers, and the test BuildFile contains an unnecessary declaration
of a link dependency on rootrflx.
This pull request removes the unnecessary includes and dependencies.

Unnecessary includes can be considered a bug, so I view this as a bug fix.

You can merge this Pull Request by running

git pull https://github.com/wmtan/cmssw RemoveUnnecessaryReflexDependency

Or view, comment on, or merge it at:

#1191
Commit Summary

  • Remove unnecessary dependency on Reflex

File Changes

Patch Links:

Thanks,
cheers, andreas

@wmtan
Copy link
Contributor Author

wmtan commented Oct 26, 2013

Ping. This appears to be fully signed, but the usual comments from cmsbuild are missing.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Oct 27, 2013
ROOT6 -- Remove unnecessary dependency on Reflex
@ktf ktf merged commit 1193965 into cms-sw:CMSSW_7_0_X Oct 27, 2013
@wmtan wmtan deleted the RemoveUnnecessaryReflexDependency branch October 29, 2013 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants