Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heavy ion common alignment producer 76 x #11934

Merged

Conversation

cmsbuild
Copy link
Contributor

This pull request includes the addition of several new common alignment AlCaReco producers that will be used on heavy ion data. Additional files edited include these producers into AlCa streams.
Automatically ported from CMSSW_7_6_X #11698 (original by @jrcastle).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_8_0_X.

Heavy ion common alignment producer 76 x

It involves the following packages:

Alignment/CommonAlignmentProducer
Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/StandardSequences
DQMOffline/Alignment

@diguida, @danduggan, @boudoul, @franzoni, @cerminar, @fabozzi, @cmsbuild, @srimanob, @deguio, @mmusich, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @tlampen, @mschrode, @cerati, @mmusich, @dgulhan, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Oct 21, 2015

please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9104/console

@diguida
Copy link
Contributor

diguida commented Oct 30, 2015

@cmsbuild please acknowledge changes

@diguida
Copy link
Contributor

diguida commented Oct 30, 2015

+1
comments by @mmusich addressed
Tests at jrcastle@143479d (run in 76X) show that the changes are satisfactory.

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9400/console

@cmsbuild
Copy link
Contributor Author

Pull request #11934 was updated. @danduggan, @boudoul, @franzoni, @fabozzi, @cmsbuild, @srimanob, @deguio, @vanbesien, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

@srimanob
Copy link
Contributor

+1
From PdmV side, new ALCARECOs are added to RelVals RECO step. This seems fine.

@mmusich
Copy link
Contributor

mmusich commented Nov 2, 2015

@deguio @vanbesien can you please check and sign again?

@deguio
Copy link
Contributor

deguio commented Nov 2, 2015

+1

davidlange6 added a commit that referenced this pull request Nov 3, 2015
…er_76X

Heavy ion common alignment producer 76 x
@davidlange6 davidlange6 merged commit 2868d4c into cms-sw:CMSSW_8_0_X Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants