Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preferred form of not-equal since python 3 eliminates <> #11960

Merged
merged 1 commit into from Oct 23, 2015

Conversation

ericvaandering
Copy link
Contributor

@Dr15Jones said 8_0_X would be a decent place to start getting rid of old python that is not compatible with python 3 but works fine in 2.6/2.7.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ericvaandering (Eric Vaandering) for CMSSW_8_0_X.

Use perferred form of not-equal since python 3 eliminates <>

It involves the following packages:

DQM/HcalMonitorModule
DQM/HcalMonitorTasks
EventFilter/HcalRawToDigi
FWCore/ParameterSet
RecoLocalCalo/HcalRecAlgos
Validation/EcalClusters

@smuzaffar, @Dr15Jones, @cvuosalo, @cmsbuild, @deguio, @slava77, @vanbesien, @danduggan can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @argiro, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 19, 2015

@cmsbuild please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9015/console

@ericvaandering ericvaandering changed the title Use perferred form of not-equal since python 3 eliminates <> Use preferred form of not-equal since python 3 eliminates <> Oct 19, 2015
@davidlt
Copy link
Contributor

davidlt commented Oct 19, 2015

Should we also cook CMSSW + Python 3.5 IB?

@davidlange6
Copy link
Contributor

do we know what externals do / do not support it ?

On Oct 19, 2015, at 5:24 PM, davidlt notifications@github.com wrote:

Should we also cook CMSSW + Python 3.5 IB?


Reply to this email directly or view it on GitHub.

@ericvaandering
Copy link
Contributor Author

No. Will break for sure as the point of these patches is to get the python as compatible as can be with 3.x while not breaking 2.6 compatibility. Actual python3 compatibility is a whole different animal.

@davidlt
Copy link
Contributor

davidlt commented Oct 19, 2015

@davidlange6 most of Python packages we ship are not required for CMSSW execution, but it's easy to check since Python 3 is default in Fedora 23. Most critical part is to make sure Framework + Python 3 is fine. Most of other changes should be mechanical.

I can experiment with that a bit on personal branch to see what works or not.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 21, 2015

@cmsbuild please test
to get a clean set of tests

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9082/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 21, 2015

+1

for #11960 931a199

  • technical change affects only test python scripts in reco category
  • jenkins tests pass and comparisons with the baseline show no differences

davidlange6 added a commit that referenced this pull request Oct 23, 2015
Use preferred form of not-equal since python 3 eliminates <>
@davidlange6 davidlange6 merged commit a5197a9 into cms-sw:CMSSW_8_0_X Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants